Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-18 Thread Teresa Johnson
On Mon, Nov 18, 2013 at 12:23 PM, Jeff Law wrote: > On 11/18/13 12:33, Teresa Johnson wrote: >> >> On Mon, Nov 18, 2013 at 7:34 AM, Steven Bosscher >> wrote: >>> >>> On Mon, Nov 18, 2013 at 3:53 PM, Teresa Johnson wrote: From a bb layout perspective it seems like it would be beneficial

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-18 Thread Jeff Law
On 11/18/13 12:33, Teresa Johnson wrote: On Mon, Nov 18, 2013 at 7:34 AM, Steven Bosscher wrote: On Mon, Nov 18, 2013 at 3:53 PM, Teresa Johnson wrote: From a bb layout perspective it seems like it would be beneficial to do compgotos before layout. Was the current position just to try to redu

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-18 Thread Jan Hubicka
> 2013-11-18 Teresa Johnson > > * gcc/cfgrtl.c (cfg_layout_initialize): Assert if we > try to go into cfglayout after bb reordering. > * gcc/passes.def: Move compgotos before bb reordering > since it goes into cfglayout. This seems resonable to me, but I can't a

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-18 Thread Teresa Johnson
On Mon, Nov 18, 2013 at 7:34 AM, Steven Bosscher wrote: > On Mon, Nov 18, 2013 at 3:53 PM, Teresa Johnson wrote: >> From a bb layout perspective it seems like it would be beneficial to >> do compgotos before layout. Was the current position just to try to >> reduce compile time by keeping the bloc

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-18 Thread Steven Bosscher
On Mon, Nov 18, 2013 at 3:53 PM, Teresa Johnson wrote: > From a bb layout perspective it seems like it would be beneficial to > do compgotos before layout. Was the current position just to try to > reduce compile time by keeping the block unified as long as possible? It was more a hack that got ou

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-18 Thread Teresa Johnson
On Sat, Nov 16, 2013 at 12:33 AM, Jan Hubicka wrote: >> When testing with -freorder-blocks-and-partition enabled, I hit a >> verification failure in an LTO profiledbootstrap. Edge forwarding >> performed when we went into cfg layout mode after bb reordering >> (during compgotos) created a situatio

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-16 Thread Jan Hubicka
> Note I haven't done an extensive check to see if compgotos is the only > phase that goes back into cfglayout mode after bb reordering is done, > that's just the one that hit this. Eventually it might be good to > prevent going into cfglayout mode after bb reordering. Can we just try to abort whe

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-16 Thread Teresa Johnson
On Sat, Nov 16, 2013 at 12:33 AM, Jan Hubicka wrote: >> When testing with -freorder-blocks-and-partition enabled, I hit a >> verification failure in an LTO profiledbootstrap. Edge forwarding >> performed when we went into cfg layout mode after bb reordering >> (during compgotos) created a situatio

Re: [PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-16 Thread Jan Hubicka
> When testing with -freorder-blocks-and-partition enabled, I hit a > verification failure in an LTO profiledbootstrap. Edge forwarding > performed when we went into cfg layout mode after bb reordering > (during compgotos) created a situation where a hot block was then > dominated by a cold block a

[PATCH] Fix lto bootstrap verification failure with -freorder-blocks-and-partition

2013-11-15 Thread Teresa Johnson
When testing with -freorder-blocks-and-partition enabled, I hit a verification failure in an LTO profiledbootstrap. Edge forwarding performed when we went into cfg layout mode after bb reordering (during compgotos) created a situation where a hot block was then dominated by a cold block and was the