Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-10 Thread Jeff Law
On 12/08/2015 09:21 AM, Marek Polacek wrote: The following is a conservative fix for this PR. This is an ICE transpiring in the new "Factor conversion in COND_EXPR" optimization added in r225722. Before this optimization kicks in, we have : ... p1_32 = (short unsigned int) _20; :

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-09 Thread Richard Biener
On Wed, Dec 9, 2015 at 3:22 PM, Marek Polacek wrote: > On Wed, Dec 09, 2015 at 11:41:44AM +0100, Richard Biener wrote: >> But I don't see why we have the asserts at all - they seem to be originated >> from >> development. IMHO factor_out_conditonal_conversion should simply return >> the new PHI

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-09 Thread Marek Polacek
On Wed, Dec 09, 2015 at 11:41:44AM +0100, Richard Biener wrote: > But I don't see why we have the asserts at all - they seem to be originated > from > development. IMHO factor_out_conditonal_conversion should simply return > the new PHI it generates instead of relying on > signle_non_signelton_ph

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-09 Thread Richard Biener
On Tue, Dec 8, 2015 at 5:21 PM, Marek Polacek wrote: > The following is a conservative fix for this PR. This is an ICE transpiring > in the new "Factor conversion in COND_EXPR" optimization added in r225722. > > Before this optimization kicks in, we have > : > ... > p1_32 = (short unsigned

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-08 Thread Kugan
On 09/12/15 03:21, Marek Polacek wrote: > The following is a conservative fix for this PR. This is an ICE transpiring > in the new "Factor conversion in COND_EXPR" optimization added in r225722. > > Before this optimization kicks in, we have > : > ... > p1_32 = (short unsigned int) _20; >

[PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-08 Thread Marek Polacek
The following is a conservative fix for this PR. This is an ICE transpiring in the new "Factor conversion in COND_EXPR" optimization added in r225722. Before this optimization kicks in, we have : ... p1_32 = (short unsigned int) _20; : ... iftmp.0_18 = (short unsigned int) _20; :