Re: [PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246)

2011-12-01 Thread Richard Guenther
On Thu, Nov 24, 2011 at 5:28 PM, Michael Matz m...@suse.de wrote: Hi, On Thu, 24 Nov 2011, Jakub Jelinek wrote: When stmt is mem = {v} {CLOBBER};, then lhs is neither SSA_NAME, but it doesn't satisfy gimple_assign_copy_p either. With this patch it will set the new_tree also to the clobber,

Re: [PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246, take 2)

2011-12-01 Thread Richard Guenther
On Thu, Nov 24, 2011 at 5:51 PM, Michael Matz m...@suse.de wrote: Hi, On Thu, 24 Nov 2011, Jakub Jelinek wrote: On Thu, Nov 24, 2011 at 05:28:00PM +0100, Michael Matz wrote: As the default defs are already automatically handled by all our ssa infrastructure (including warning and

Re: [PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246, take 2)

2011-12-01 Thread Michael Matz
Hi, On Thu, 1 Dec 2011, Richard Guenther wrote: As the default defs are already automatically handled by all our ssa infrastructure (including warning and propagation machinery) I think it would be best to generate such one instead of a clobber for the RHS. So like this? I

[PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246)

2011-11-24 Thread Jakub Jelinek
Hi! When stmt is mem = {v} {CLOBBER};, then lhs is neither SSA_NAME, but it doesn't satisfy gimple_assign_copy_p either. With this patch it will set the new_tree also to the clobber, making it clear that the next iteration uses unitialized variable. Bootstrapped/regtested on x86_64-linux and

Re: [PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246)

2011-11-24 Thread Michael Matz
Hi, On Thu, 24 Nov 2011, Jakub Jelinek wrote: When stmt is mem = {v} {CLOBBER};, then lhs is neither SSA_NAME, but it doesn't satisfy gimple_assign_copy_p either. With this patch it will set the new_tree also to the clobber, making it clear that the next iteration uses unitialized variable.

[PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246, take 2)

2011-11-24 Thread Jakub Jelinek
On Thu, Nov 24, 2011 at 05:28:00PM +0100, Michael Matz wrote: As the default defs are already automatically handled by all our ssa infrastructure (including warning and propagation machinery) I think it would be best to generate such one instead of a clobber for the RHS. So like this?

Re: [PATCH] Fix predcom ICE introduced by var clobber changes (PR tree-optimization/51246, take 2)

2011-11-24 Thread Michael Matz
Hi, On Thu, 24 Nov 2011, Jakub Jelinek wrote: On Thu, Nov 24, 2011 at 05:28:00PM +0100, Michael Matz wrote: As the default defs are already automatically handled by all our ssa infrastructure (including warning and propagation machinery) I think it would be best to generate such one