[PATCH] Fix rtl sharing bug in rs6000_frame_related (PR target/78614)

2016-11-30 Thread Jakub Jelinek
Hi! As mentioned in the PR, the rs6000_frame_related rewrite broke rtl sharing whose --enable-checking=rtl verification has been broken for the last 3.5 years until today. The problem is that simplify_replace_rtx doesn't unshare everything, only the minimum needed to replace what is needed without

Re: [PATCH] Fix rtl sharing bug in rs6000_frame_related (PR target/78614)

2016-11-30 Thread Alan Modra
On Wed, Nov 30, 2016 at 11:27:40PM +0100, Jakub Jelinek wrote: > The last hunk just removes unnecessary condition, if the condition is not > true, we return from the function already earlier and don't do any > replacements. Yeah, that was a leftover from an earlier revision of the patch that remov

Re: [PATCH] Fix rtl sharing bug in rs6000_frame_related (PR target/78614)

2016-11-30 Thread Segher Boessenkool
On Wed, Nov 30, 2016 at 11:27:40PM +0100, Jakub Jelinek wrote: > As mentioned in the PR, the rs6000_frame_related rewrite broke rtl sharing > whose --enable-checking=rtl verification has been broken for the last 3.5 > years until today. Great eh! I am very scared. > Markus said he has bootstrapp

Re: [PATCH] Fix rtl sharing bug in rs6000_frame_related (PR target/78614)

2016-11-30 Thread Alan Modra
On Wed, Nov 30, 2016 at 11:27:40PM +0100, Jakub Jelinek wrote: > Markus said he has bootstrapped this patch with rtl checking on powerpc64. I repeated the exercise and found a stage1 bootstrap failure due to invalid rtl sharing on powerpc64le-linux, using AS="/home/amodra/gnu/bin/as" LD="/home/am

Re: [PATCH] Fix rtl sharing bug in rs6000_frame_related (PR target/78614)

2016-11-30 Thread Alan Modra
On Thu, Dec 01, 2016 at 12:36:49PM +1030, Alan Modra wrote: > On Wed, Nov 30, 2016 at 11:27:40PM +0100, Jakub Jelinek wrote: > > Markus said he has bootstrapped this patch with rtl checking on powerpc64. > > I repeated the exercise and found a stage1 bootstrap failure due to > invalid rtl sharing