Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-20 Thread Jan Hubicka
> > gcc/ > > 2015-03-11 Yvan Roux > > > > Backport from trunk r216841. > > 2014-10-29 Martin Liska > > > > PR ipa/63587 > > * cgraphunit.c (cgraph_node::expand_thunk): Only VAR_DECLs are put > > to local declarations. > > * function.c (add_local_decl): Implementation m

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-20 Thread Yvan Roux
Ping. On 11 March 2015 at 16:38, Yvan Roux wrote: > Hi, > > PR ipa/65236 * cgraphunit.c (cgraph_node::expand_thunk): Enable return slot opt. >> >> This bugfix adds ipa-icf-6.C test which failed on 4.9 branch as >> ipa-icf is not backported on that branch. I

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-11 Thread Yvan Roux
Hi, >>> PR ipa/65236 >>> * cgraphunit.c (cgraph_node::expand_thunk): Enable return slot >>> opt. > > This bugfix adds ipa-icf-6.C test which failed on 4.9 branch as > ipa-icf is not backported on that branch. Is the bugfix still > relevant and we can dropped the testcase

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-10 Thread Yvan Roux
Honza, On 10 March 2015 at 20:09, Yvan Roux wrote: > On 10 March 2015 at 19:18, Jan Hubicka wrote: >>> Hi >>> >>> On 9 March 2015 at 17:07, Yvan Roux wrote: >>> > Hi, >>> > >>> > As added in the PR, this issue is also present on 4.9 branch and >>> > affects at least arm-linux-gnueabihf target (

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-10 Thread Yvan Roux
On 10 March 2015 at 19:18, Jan Hubicka wrote: >> Hi >> >> On 9 March 2015 at 17:07, Yvan Roux wrote: >> > Hi, >> > >> > As added in the PR, this issue is also present on 4.9 branch and >> > affects at least arm-linux-gnueabihf target (as reported in PR61207). >> > >> > I've backported it in the 4

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-10 Thread Jan Hubicka
> Hi > > On 9 March 2015 at 17:07, Yvan Roux wrote: > > Hi, > > > > As added in the PR, this issue is also present on 4.9 branch and > > affects at least arm-linux-gnueabihf target (as reported in PR61207). > > > > I've backported it in the 4.9 branch with the attached patch. The > > difference

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-10 Thread Yvan Roux
Hi On 9 March 2015 at 17:07, Yvan Roux wrote: > Hi, > > As added in the PR, this issue is also present on 4.9 branch and > affects at least arm-linux-gnueabihf target (as reported in PR61207). > > I've backported it in the 4.9 branch with the attached patch. The > difference with the trunk code

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-03-09 Thread Yvan Roux
Hi, As added in the PR, this issue is also present on 4.9 branch and affects at least arm-linux-gnueabihf target (as reported in PR61207). I've backported it in the 4.9 branch with the attached patch. The difference with the trunk code is due the code introduced by PR63587 fix (I didn't checked

Re: [PATCH] Fix thunk expansion (PR ipa/64896)

2015-02-06 Thread Jan Hubicka
> Hi! > > As discussed in the PR, for functions that return an aggregate that is not > aggregate_value_p (i.e. returned in registers), using RESULT_DECL is > undesirable, that's not what we normally emit for user code. > > So, this patch instead uses a temporary, which is optimized right now as >

[PATCH] Fix thunk expansion (PR ipa/64896)

2015-02-06 Thread Jakub Jelinek
Hi! As discussed in the PR, for functions that return an aggregate that is not aggregate_value_p (i.e. returned in registers), using RESULT_DECL is undesirable, that's not what we normally emit for user code. So, this patch instead uses a temporary, which is optimized right now as much as similar