Re: [PATCH] Fix up 20181120-1.c testcase on big-endian (PR rtl-optimization/85925, take 2)

2018-11-21 Thread Segher Boessenkool
On Wed, Nov 21, 2018 at 08:12:44PM +0100, Jakub Jelinek wrote: > On Wed, Nov 21, 2018 at 12:07:51PM -0600, Segher Boessenkool wrote: > > > Admittedly, it might be better if the initializer was 0x1010101 or say > > > 0x4030201 because on big endian in particular 0x10101 has the top 15 bits > > > all

[PATCH] Fix up 20181120-1.c testcase on big-endian (PR rtl-optimization/85925, take 2)

2018-11-21 Thread Jakub Jelinek
Hi! On Wed, Nov 21, 2018 at 12:07:51PM -0600, Segher Boessenkool wrote: > > Admittedly, it might be better if the initializer was 0x1010101 or say > > 0x4030201 because on big endian in particular 0x10101 has the top 15 bits > > all zero and thus that is what is in u.f1, so if the bug can be repro

Re: [PATCH] Fix up 20181120-1.c testcase on big-endian (PR rtl-optimization/85925)

2018-11-21 Thread Segher Boessenkool
On Wed, Nov 21, 2018 at 06:31:43PM +0100, Jakub Jelinek wrote: > > > As mentioned in the PR, the testcase fails on big-endian targets. > > > The following patch tweaks it so that it does not fail there and still > > > checks for the original bug. > > > > It relies on a certain bitfield layout, not

Re: [PATCH] Fix up 20181120-1.c testcase on big-endian (PR rtl-optimization/85925)

2018-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2018 at 11:23:38AM -0600, Segher Boessenkool wrote: > Hi, > > On Wed, Nov 21, 2018 at 02:13:55PM +0100, Jakub Jelinek wrote: > > As mentioned in the PR, the testcase fails on big-endian targets. > > The following patch tweaks it so that it does not fail there and still > > checks f

Re: [PATCH] Fix up 20181120-1.c testcase on big-endian (PR rtl-optimization/85925)

2018-11-21 Thread Segher Boessenkool
Hi, On Wed, Nov 21, 2018 at 02:13:55PM +0100, Jakub Jelinek wrote: > As mentioned in the PR, the testcase fails on big-endian targets. > The following patch tweaks it so that it does not fail there and still > checks for the original bug. It relies on a certain bitfield layout, not just on LE. I

[PATCH] Fix up 20181120-1.c testcase on big-endian (PR rtl-optimization/85925)

2018-11-21 Thread Jakub Jelinek
Hi! As mentioned in the PR, the testcase fails on big-endian targets. The following patch tweaks it so that it does not fail there and still checks for the original bug. Tested on x86_64-linux and i686-linux, ok for trunk and release branches? 2018-11-21 Jakub Jelinek PR rtl-optimiza