Re: [PATCH] Fix up _cpp_find_file

2013-02-28 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> 2013-02-27 Jakub Jelinek Jakub> * files.c (_cpp_find_file): If returning early, before storing Jakub> something to *hash_slot and *hash_slot is NULL, call htab_clear_slot Jakub> on it. Access *hash_slot using void * type rather than Jakub> st

[PATCH] Fix up _cpp_find_file

2013-02-27 Thread Jakub Jelinek
Hi! As discussed on IRC, this function calls htab_find_slot_with_hash with INSERT early, but sometimes decides to return without actually making sure *hash_slot is non-NULL. That can result in broken hash table, because NULL is empty entry and could break lookup for some other hash value. Fixed