Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920)

2019-02-14 Thread Mike Stump
On Feb 13, 2019, at 1:09 AM, Jakub Jelinek wrote: > > ok for trunk? Ok.

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-14 Thread Mike Stump
On Feb 13, 2019, at 5:37 AM, Jakub Jelinek wrote: > Here is an updated patch that documents it. Bootstrapped/regtested on > x86_64-linux and i686-linux, ok for trunk? Ok.

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-13 Thread David Malcolm
On Wed, 2019-02-13 at 20:08 +0100, Iain Buclaw wrote: > On Wed, 13 Feb 2019 at 14:37, Jakub Jelinek wrote: > > > > On Wed, Feb 13, 2019 at 10:22:14AM +, Andrew Stubbs wrote: > > > On 13/02/2019 09:09, Jakub Jelinek wrote: > > > > To make it work together with doing llvm_binutils only once, >

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-13 Thread Iain Buclaw
On Wed, 13 Feb 2019 at 14:37, Jakub Jelinek wrote: > > On Wed, Feb 13, 2019 at 10:22:14AM +, Andrew Stubbs wrote: > > On 13/02/2019 09:09, Jakub Jelinek wrote: > > > To make it work together with doing llvm_binutils only once, the global > > > now > > > has multiple values > > > 0 - disallow

[PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2019 at 10:22:14AM +, Andrew Stubbs wrote: > On 13/02/2019 09:09, Jakub Jelinek wrote: > > To make it work together with doing llvm_binutils only once, the global now > > has multiple values > > 0 - disallow blank lines > > 1 - allow them for a single test only, reset after

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920)

2019-02-13 Thread Andrew Stubbs
On 13/02/2019 09:09, Jakub Jelinek wrote: To make it work together with doing llvm_binutils only once, the global now has multiple values 0 - disallow blank lines 1 - allow them for a single test only, reset after testing it in gcc-dg-prune 2 - allow it for all tests (llvm_binutils) FWIW, this

[PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920)

2019-02-13 Thread Jakub Jelinek
Hi! The following patch fixes various testsuite issues related to allow_blank_lines. One issue is that even when llvm_binutils effective target is now cached so it is checked just once (per runtest invocation), if the first test invoked emits some diagnostics, that diagnostics in the log file