[PATCH] Fix use of singleton in optinfo framework

2020-04-06 Thread Gustavo Romero via Gcc-patches
Currently an use of get() method of dump_context singleton in optinfo framework causes a new class to be instantiated, which calls the singleton dtor when the class is destroyed, freeing memory that is referenced after free() is called, generating an ICE error. This commit fixes the issue by using

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-06 Thread David Malcolm via Gcc-patches
On Mon, 2020-04-06 at 19:44 -0400, Gustavo Romero wrote: Thanks for this patch. The patch looks correct, but I'm not sure that the description of the problem is exact in every detail. I think you've run into a bug in code I wrote; sorry. > Currently an use of get() method of dump_context single

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-06 Thread David Malcolm via Gcc-patches
On Mon, 2020-04-06 at 21:42 -0400, David Malcolm via Gcc-patches wrote: > On Mon, 2020-04-06 at 19:44 -0400, Gustavo Romero wrote: > > Thanks for this patch. > > The patch looks correct, but I'm not sure that the description of the > problem is exact in every detail. I think you've run into a bu

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-06 Thread Jakub Jelinek via Gcc-patches
On Mon, Apr 06, 2020 at 09:42:17PM -0400, David Malcolm via Gcc-patches wrote: > > 2020-04-06 Gustavo Romero > > > > * dumpfile.c: > > (selftest::temp_dump_context::temp_dump_context): Fix ctor. > > --- > > gcc/dumpfile.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-07 Thread Gustavo Romero via Gcc-patches
Hi David, On 04/06/2020 10:42 PM, David Malcolm wrote: On Mon, 2020-04-06 at 19:44 -0400, Gustavo Romero wrote: Thanks for this patch. The patch looks correct, but I'm not sure that the description of the problem is exact in every detail. I think you've run into a bug in code I wrote; sorry.

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-07 Thread Gustavo Romero via Gcc-patches
On 04/07/2020 03:24 AM, Jakub Jelinek wrote: On Mon, Apr 06, 2020 at 09:42:17PM -0400, David Malcolm via Gcc-patches wrote: 2020-04-06 Gustavo Romero * dumpfile.c: (selftest::temp_dump_context::temp_dump_context): Fix ctor. --- gcc/dumpfile.c | 2 +- 1 file changed, 1 inse

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-08 Thread Piotr Kubaj via Gcc-patches
Hi, since there has been some misunderstanding, I will explain. There are 4 possible options here: 1. FreeBSD 12.1-RELEASE, powerpc, GCC 4.2 2. FreeBSD 13.0-CURRENT (head branch), powerpc, LLVM 10.0.0 3. FreeBSD 12.1-RELEASE, powerpc64, GCC 4.2 4. FreeBSD 13.0-CURRENT (head branch), powerpc64, L

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-13 Thread Hans-Peter Nilsson
On Mon, 6 Apr 2020, Gustavo Romero via Gcc-patches wrote: > Currently an use of get() method of dump_context singleton in optinfo > framework causes a new class to be instantiated, which calls the singleton > dtor when the class is destroyed, freeing memory that is referenced after > free() is cal

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-21 Thread Gustavo Romero via Gcc-patches
Hi Hans, On 4/14/20 12:33 AM, Hans-Peter Nilsson wrote: Sadly this patch doesn't fix PR bootstrap/87252; I just checked against f8e72b8d9f2:f81653ba8c1:2dd4ceacd8b (truncated from LAST_UPDATED; I don't remember which field is the actual commit). So, would you mind to tell me precisely how to r

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-21 Thread Hans-Peter Nilsson
On Tue, 21 Apr 2020, Gustavo Romero wrote: > Hi Hans, Hi Gus, > On 4/14/20 12:33 AM, Hans-Peter Nilsson wrote: > > Sadly this patch doesn't fix PR bootstrap/87252; I just checked > > against f8e72b8d9f2:f81653ba8c1:2dd4ceacd8b (truncated from > > LAST_UPDATED; I don't remember which field is the