Re: [PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-11-16 Thread H.J. Lu
On Tue, Oct 22, 2013 at 6:09 AM, Jakub Jelinek wrote: > Hi! > > I've spent over two days looking at reassoc, fixing spots where > we invalidly reused SSA_NAMEs (this results in wrong-debug, as the added > guality testcases show, even some ICEs (pr58791-3.c) and wrong range info > for SSA_NAMEs) an

Re: [PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-10-23 Thread Jeff Law
On 10/23/13 04:35, Jakub Jelinek wrote: For debug info quality it actually isn't just about using different SSA_NAME, but also not reusing the defining stmt; only then the code will magically try to create debug temporaries and expressions from the old dead defining stmt. Joys. Something else t

Re: [PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-10-23 Thread Jakub Jelinek
On Wed, Oct 23, 2013 at 01:54:05PM +0200, Richard Biener wrote: > I'm ok with the patch. Not sure if we want to backport it at all - we > will only have wrong-debug issues (well, "only"). I've added some comments and one assert (that the uids are non-zero). Because of that assertion I'll bootstra

Re: [PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-10-23 Thread Richard Biener
On Wed, 23 Oct 2013, Jakub Jelinek wrote: > On Tue, Oct 22, 2013 at 12:47:41PM -0600, Jeff Law wrote: > > On 10/22/13 07:09, Jakub Jelinek wrote: > > >I've spent over two days looking at reassoc, fixing spots where > > >we invalidly reused SSA_NAMEs (this results in wrong-debug, as the added > > >

Re: [PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-10-23 Thread Jakub Jelinek
On Tue, Oct 22, 2013 at 12:47:41PM -0600, Jeff Law wrote: > On 10/22/13 07:09, Jakub Jelinek wrote: > >I've spent over two days looking at reassoc, fixing spots where > >we invalidly reused SSA_NAMEs (this results in wrong-debug, as the added > >guality testcases show, even some ICEs (pr58791-3.c)

Re: [PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-10-22 Thread Jeff Law
On 10/22/13 07:09, Jakub Jelinek wrote: Hi! I've spent over two days looking at reassoc, fixing spots where we invalidly reused SSA_NAMEs (this results in wrong-debug, as the added guality testcases show, even some ICEs (pr58791-3.c) and wrong range info for SSA_NAMEs) This is something we all n

[PATCH] Fix various reassoc issues (PR tree-optimization/58791, tree-optimization/58775)

2013-10-22 Thread Jakub Jelinek
Hi! I've spent over two days looking at reassoc, fixing spots where we invalidly reused SSA_NAMEs (this results in wrong-debug, as the added guality testcases show, even some ICEs (pr58791-3.c) and wrong range info for SSA_NAMEs) and cleaning up the stmt scheduling stuff (e.g. all gsi_move* calls