Re: [PATCH] Fix whitespace in comments.

2014-09-22 Thread Jeff Law
On 09/20/14 08:48, Tobias Burnus wrote: Hi Joost and Thomas, On 20.09.2014 12:02, Thomas Koenig wrote: A somewhat trivial patch to cleanup whitespace issues in comments: sed s/\. \*\//\. \*\//g Tested with a recompile only. Ok for trunk ? OK. (Obvious, really). I want to point a downside

[PATCH] Fix whitespace in comments.

2014-09-20 Thread VandeVondele Joost
A somewhat trivial patch to cleanup whitespace issues in comments: sed s/\. \*\//\. \*\//g Tested with a recompile only. Ok for trunk ? gcc/fortran/ChangeLog: 2014-09-20 Joost VandeVondele vond...@gcc.gnu.org * trans-expr.c (gfc_reset_vptr): Fix comment whitespace.

Re: [PATCH] Fix whitespace in comments.

2014-09-20 Thread Thomas Koenig
Hi Joost, A somewhat trivial patch to cleanup whitespace issues in comments: sed s/\. \*\//\. \*\//g Tested with a recompile only. Ok for trunk ? OK. (Obvious, really). Thomas

Re: [PATCH] Fix whitespace in comments.

2014-09-20 Thread Tobias Burnus
Hi Joost and Thomas, On 20.09.2014 12:02, Thomas Koenig wrote: A somewhat trivial patch to cleanup whitespace issues in comments: sed s/\. \*\//\. \*\//g Tested with a recompile only. Ok for trunk ? OK. (Obvious, really). I want to point a downside of massive code changes: It makes it

RE: [PATCH] Fix whitespace in comments.

2014-09-20 Thread VandeVondele Joost
Hi Tobias, However, I wanted to point out that seemingly trivial and obviously correct patches can have a downside. (One can still do such changes, but at least one should have weighted them against the downside.) I agree, that's why I asked explicitly. Joost