Re: [PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-12 Thread Richard Biener
On 11/12/13 2:03 PM, Tom de Vries wrote: > On 11-11-13 14:17, Richard Biener wrote: >> On Mon, 11 Nov 2013, Tom de Vries wrote: >> >>> On 11/11/13 10:50, Richard Biener wrote: On Sat, 9 Nov 2013, Tom de Vries wrote: > Bootstrapped and regtested on x86_64. > > OK for trunk? >>>

Re: [PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-12 Thread Tom de Vries
On 11-11-13 14:17, Richard Biener wrote: On Mon, 11 Nov 2013, Tom de Vries wrote: On 11/11/13 10:50, Richard Biener wrote: On Sat, 9 Nov 2013, Tom de Vries wrote: Bootstrapped and regtested on x86_64. OK for trunk? Comments inline diff --git a/gcc/tree-ssa-tail-merge.c b/gcc/tree-ssa-tai

Re: [PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-11 Thread Richard Biener
On Mon, 11 Nov 2013, Tom de Vries wrote: > On 11/11/13 10:50, Richard Biener wrote: > > On Sat, 9 Nov 2013, Tom de Vries wrote: > >> Bootstrapped and regtested on x86_64. > >> > >> OK for trunk? > > > > Comments inline > > > > > > diff --git a/gcc/tree-ssa-tail-merge.c b/gcc/tree-ssa-tail-merge

Re: [PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-11 Thread Tom de Vries
On 11/11/13 10:50, Richard Biener wrote: > On Sat, 9 Nov 2013, Tom de Vries wrote: >> Bootstrapped and regtested on x86_64. >> >> OK for trunk? > > Comments inline > > > diff --git a/gcc/tree-ssa-tail-merge.c b/gcc/tree-ssa-tail-merge.c > index 98b5882..43516a7 100644 > --- a/gcc/tree-ssa-tail-m

Re: [PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-11 Thread Richard Biener
On Sat, 9 Nov 2013, Tom de Vries wrote: > Richard, > > Consider the test-case test.c: > ... > int z; > int x; > > void > f (int c, int d) > { > if (c) > z = 5; > else > { > if (d) > x = 4; > z = 5; > } > } > ... > > Atm, we don't tail-merge the 'z = 5' blocks,

Re: [PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-10 Thread Bernhard Reutner-Fischer
On Sat, Nov 09, 2013 at 05:30:00PM +0100, Tom de Vries wrote: >Richard, > >Consider the test-case test.c: >... >int z; >int x; > >void >f (int c, int d) >{ > if (c) >z = 5; > else >{ > if (d) > x = 4; > z = 5; >} >} >... > >Atm, we don't tail-merge the 'z = 5' blocks,

[PATCH] Handle GIMPLE_ASSIGNs with different vuse in gimple_equal_p

2013-11-09 Thread Tom de Vries
Richard, Consider the test-case test.c: ... int z; int x; void f (int c, int d) { if (c) z = 5; else { if (d) x = 4; z = 5; } } ... Atm, we don't tail-merge the 'z = 5' blocks, because gimple_equal_p returns false for the 'z = 5' statements. The relevant cod