Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Bin.Cheng
On Fri, Jan 9, 2015 at 6:03 AM, Jeff Law wrote: > On 01/08/15 08:58, Kito Cheng wrote: >> >> Hi Jeff: >> >> After discussion with Bin, he prefer just use >> gcc.c-torture/execute/scal-to-vec1.c >> instead of introduce new one, do you have any further comment on this >> patch? > > Ah, if there's an

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Jeff Law
On 01/08/15 08:58, Kito Cheng wrote: Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? Ah, if there's an existing test, then we certainly don't need a new one. Jeff

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Jeff Law
On 01/08/15 08:58, Kito Cheng wrote: Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? If you can use the existing test, then that's good for me. I believe that was the last q

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Kito Cheng
Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? On Thu, Jan 8, 2015 at 9:29 AM, Bin.Cheng wrote: > On Wed, Jan 7, 2015 at 8:28 PM, Kito Cheng wrote: >> Hi Bin: >> >> It's 2 m

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-07 Thread Bin.Cheng
On Wed, Jan 7, 2015 at 8:28 PM, Kito Cheng wrote: > Hi Bin: > > It's 2 more line than gcc.c-torture/execute/scal-to-vec1.c since it's > need specific compilation > flag and specific target to reproduce this issue, > and it's can't reproduce by normal testing flow with > arm-*-linux-gnueabi (due to

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-07 Thread Kito Cheng
Hi Bin: It's 2 more line than gcc.c-torture/execute/scal-to-vec1.c since it's need specific compilation flag and specific target to reproduce this issue, and it's can't reproduce by normal testing flow with arm-*-linux-gnueabi (due to lack -fPIC flag), so I prefer duplicate this case into gcc.targ

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-07 Thread Bin.Cheng
On Wed, Jan 7, 2015 at 4:03 PM, Kito Cheng wrote: > Hi Jeff: > > It's updated patch,bootstrapped and run regression tested on arm-eabi, > arm-none-linux-uclibcgnueabi, x86_64-unknown-linux-gnu and nds32le-elf > without introducing regression. > > Thanks for your review :) > > 2015-01-07 Kito Chen

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-07 Thread Kito Cheng
Hi Jeff: It's updated patch,bootstrapped and run regression tested on arm-eabi, arm-none-linux-uclibcgnueabi, x86_64-unknown-linux-gnu and nds32le-elf without introducing regression. Thanks for your review :) 2015-01-07 Kito Cheng PR target/64348 * lra-constraints.c (split_re

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-06 Thread Vladimir Makarov
On 2015-01-05 8:40 PM, Bin.Cheng wrote: On Tue, Jan 6, 2015 at 7:36 AM, Vladimir Makarov wrote: On 2015-01-05 12:31 PM, Jeff Law wrote: On 01/05/15 00:44, Kito Cheng wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store an

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Bin.Cheng
On Tue, Jan 6, 2015 at 7:36 AM, Vladimir Makarov wrote: > > On 2015-01-05 12:31 PM, Jeff Law wrote: >> >> On 01/05/15 00:44, Kito Cheng wrote: >>> >>> Hi Vladimir: >>>This patch has a discusses with you in May 2014, this patch is about >>> the caller-save register store and restore instruction

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Vladimir Makarov
On 2015-01-05 12:31 PM, Jeff Law wrote: On 01/05/15 00:44, Kito Cheng wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore instruction generation, the current LRA implementation will miss caller-save store/restore

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Jeff Law
On 01/05/15 00:44, Kito Cheng wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore instruction generation, the current LRA implementation will miss caller-save store/restore instruction if need one more instruction.

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Bin.Cheng
On Mon, Jan 5, 2015 at 3:44 PM, Kito Cheng wrote: > Hi Vladimir: > This patch has a discusses with you in May 2014, this patch is about > the caller-save register store and restore instruction generation, the > current LRA implementation will miss caller-save store/restore > instruction if need

[PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-04 Thread Kito Cheng
Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore instruction generation, the current LRA implementation will miss caller-save store/restore instruction if need one more instruction. You said you will investigate for this