Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2013-01-24 Thread Torvald Riegel
On Mon, 2012-12-17 at 13:52 +0400, Dmitry Vyukov wrote: resend in plain text On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov dvyu...@google.com wrote: On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel trie...@redhat.com wrote: On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: On

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2013-01-24 Thread Dmitry Vyukov
On Thu, Jan 24, 2013 at 9:29 PM, Torvald Riegel trie...@redhat.com wrote: On Mon, 2012-12-17 at 13:52 +0400, Dmitry Vyukov wrote: resend in plain text On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov dvyu...@google.com wrote: On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel trie...@redhat.com

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2013-01-24 Thread Torvald Riegel
On Thu, 2013-01-24 at 21:44 +0400, Dmitry Vyukov wrote: On Thu, Jan 24, 2013 at 9:29 PM, Torvald Riegel trie...@redhat.com wrote: On Mon, 2012-12-17 at 13:52 +0400, Dmitry Vyukov wrote: I think the simplest way to solve it for now, it to use... well, single global lock. I.e. replace

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-17 Thread Dmitry Vyukov
resend in plain text On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov dvyu...@google.com wrote: On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel trie...@redhat.com wrote: On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote:

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-14 Thread Torvald Riegel
On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote: On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek ja...@redhat.com wrote: Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. The problem is that asan.c pass

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-14 Thread Torvald Riegel
On Fri, 2012-12-14 at 13:44 +0400, Dmitry Vyukov wrote: On Thu, Dec 13, 2012 at 1:02 PM, Jakub Jelinek ja...@redhat.com wrote: Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. The problem is that asan.c pass adds calls to builtins that weren't there before and TM is

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote: On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek ja...@redhat.com wrote: Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. The problem is that asan.c pass adds calls to builtins that weren't there before and TM

[PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Jakub Jelinek
Hi! Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. The problem is that asan.c pass adds calls to builtins that weren't there before and TM is upset about it. The __asan_report* are all like abort, in correctly written program they shouldn't have a user visible effect, in bad

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: PR sanitizer/55508 * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): New. * asan.c (ATTR_TMPURE_NOTHROW_LEAF_LIST, ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): Define. *

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Jack Howarth
On Wed, Dec 12, 2012 at 08:50:33PM +0100, Jakub Jelinek wrote: Hi! Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. The problem is that asan.c pass adds calls to builtins that weren't there before and TM is upset about it. The __asan_report* are all like abort, in

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Richard Henderson
On 12/12/2012 11:50 AM, Jakub Jelinek wrote: 2012-12-12 Jakub Jelinek ja...@redhat.com PR sanitizer/55508 * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): New. * asan.c (ATTR_TMPURE_NOTHROW_LEAF_LIST,

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Dmitry Vyukov
On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. The problem is that asan.c pass adds calls to builtins that weren't there before and TM is upset about it. The __asan_report* are all like abort, in

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Dmitry Vyukov
On Thu, Dec 13, 2012 at 1:58 AM, Richard Henderson r...@redhat.com wrote: On 12/12/2012 11:50 AM, Jakub Jelinek wrote: 2012-12-12 Jakub Jelinek ja...@redhat.com PR sanitizer/55508 * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST):