Re: [PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)

2021-11-08 Thread Iain Sandoe
> On 7 Nov 2021, at 22:50, Matt Jacobson wrote: > > >> On Oct 25, 2021, at 5:43 AM, Iain Sandoe wrote: >> >> Did you test objective-c++ on Darwin? >> >> I see a lot of fails of the form: >> Excess errors: >> : error: initialization of a flexible array member [-Wpedantic] > > Looked into

Re: [PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)

2021-11-07 Thread Matt Jacobson via Gcc-patches
> On Oct 25, 2021, at 5:43 AM, Iain Sandoe wrote: > > Did you test objective-c++ on Darwin? > > I see a lot of fails of the form: > Excess errors: > : error: initialization of a flexible array member [-Wpedantic] Looked into this. It’s happening because obj-c++.dg/dg.exp has: set

Re: [PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)

2021-10-25 Thread Iain Sandoe
Hi Matt, > On 23 Oct 2021, at 09:46, Iain Sandoe via Gcc-patches > wrote: > >> On 20 Oct 2021, at 04:51, Matt Jacobson via Gcc-patches >> wrote: >> >> >>> On Sep 26, 2021, at 11:45 PM, Matt Jacobson wrote: >>> >>> Fix protocol list layout for non-LP64. clang and objc4 both give the >>>

Re: [PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)

2021-10-23 Thread Iain Sandoe via Gcc-patches
Hi Matt, sorry for slow response, unavoidable external factors have been keeping me away from the computer (for both $dayjob and and volunteer stuff). > On 20 Oct 2021, at 04:51, Matt Jacobson via Gcc-patches > wrote: > > >> On Sep 26, 2021, at 11:45 PM, Matt Jacobson wrote: >> >> Fix

Re: [PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)

2021-10-19 Thread Matt Jacobson via Gcc-patches
> On Sep 26, 2021, at 11:45 PM, Matt Jacobson wrote: > > Fix protocol list layout for non-LP64. clang and objc4 both give the `count` > field as `long`, not `intptr_t`. Those are the same on LP64, but not > everywhere. For non-LP64, this fixes binary compatibility with clang-built >

[PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)

2021-09-26 Thread Matt Jacobson via Gcc-patches
Fix protocol list layout for non-LP64. clang and objc4 both give the `count` field as `long`, not `intptr_t`. Those are the same on LP64, but not everywhere. For non-LP64, this fixes binary compatibility with clang-built classes. This was more complicated than I anticipated, because the