Hi Harald,
On 22.09.21 21:47, Harald Anlauf via Fortran wrote:
while still feeling somewhat unsure (given my previous comment
and the discussion), I think your patch is basically OK.
However, your testcase has a { dg-do compile }, so it does not
really do any runtime tests. Is that intended?
Patch PING – see comment in the follow-up email of the patch email - and
in the email(s) before in that thread.
Tobias
On 07.09.21 16:33, Tobias Burnus wrote:
Now I actually tested the patch – and fixed some issues.
OK? – It does add support for 'allocated(a[i])' by treating
it as
t;gcc-patches"
> Betreff: [Patch] Fortran: Handle allocated() with coindexed scalars [PR93834]
> (was: [PATCH] PR fortran/93834 - [9/10/11/12 Regression] ICE in
> trans_caf_is_present, at fortran/trans-intrinsic.c:8469)
>
> Now I actually tested the patch – and fixed
Now I actually tested the patch – and fixed some issues.
OK? – It does add support for 'allocated(a[i])' by treating
it as 'allocated(a)', as 'a' must be collectively allocated
("established") on all images of the team.*
'a[i]' is (probably) an allocatable, following Malcolm in
answer to my
Hi Harald,
I spend yesterday about two hours with this. Now I am still
tired but understand more. I think the confusion between the
two of us is due to wording and in which directions the
thoughts then go:
Talking about coindexed, all of a[i], b[i]%c and c%d[i] are
coindexed and there are many
Hi Tobias,
> Consider:
>
> type t
>integer, allocatable :: a
> end type t
>
> type(t) :: var[*]
> print *, allocated(var%a)
> print *, allocated(var[1]%a)
> end
what is the problem here? Can you elaborate?
BTW: Intel accepts it, we (currently) accept it, my patch does not change
Hi Harald,
On 24.08.21 22:36, Harald Anlauf via Fortran wrote:
here's a pretty obvious one: we didn't properly check the arguments
for intrinsics when these had to be ALLOCATABLE and in the case that
argument was a coarray object. Simple solution: just reuse a check
that was used for pointer
PING!
> Gesendet: Dienstag, 24. August 2021 um 22:36 Uhr
> Von: "Harald Anlauf"
> An: "fortran" , "gcc-patches"
> Betreff: [PATCH] PR fortran/93834 - [9/10/11/12 Regression] ICE in
> trans_caf_is_present, at fortran/trans-intrinsic.c:8469
>
>
Dear Fortranners,
here's a pretty obvious one: we didn't properly check the arguments
for intrinsics when these had to be ALLOCATABLE and in the case that
argument was a coarray object. Simple solution: just reuse a check
that was used for pointer etc.
Regtested on x86_64-pc-linux-gnu. OK for
