Re: [PATCH] PR other/69554: avoid excessive source printing for widely-separated locations

2016-02-12 Thread Jeff Law
On 02/09/2016 01:54 PM, David Malcolm wrote: gcc/ChangeLog: PR other/69554 * diagnostic-show-locus.c (struct line_span): New struct. (layout::get_first_line): Delete. (layout::get_last_line): Delete. (layout::get_num_line_spans): New member function.

Re: [PATCH] PR other/69554: avoid excessive source printing for widely-separated locations

2016-02-12 Thread David Malcolm
On Fri, 2016-02-12 at 11:25 -0700, Jeff Law wrote: > On 02/09/2016 01:54 PM, David Malcolm wrote: > > > gcc/ChangeLog: > > PR other/69554 > > * diagnostic-show-locus.c (struct line_span): New struct. > > (layout::get_first_line): Delete. > > (layout::get_last_line): Delete. > >

Re: [PATCH] PR other/69554: avoid excessive source printing for widely-separated locations

2016-02-12 Thread Jeff Law
On 02/12/2016 12:06 PM, David Malcolm wrote: On Fri, 2016-02-12 at 11:25 -0700, Jeff Law wrote: On 02/09/2016 01:54 PM, David Malcolm wrote: gcc/ChangeLog: PR other/69554 * diagnostic-show-locus.c (struct line_span): New struct. (layout::get_first_line): Delete.

[PATCH] PR other/69554: avoid excessive source printing for widely-separated locations

2016-02-09 Thread David Malcolm
PR other/69554 describes a regression seen from the Fortran frontend when issuing a diagnostic containing more than one location: if the locations are within the same file (and hence not filtered by the existing sanitization code), diagnostic_show_locus could print all of the lines of the source

Re: [PATCH] PR other/69554: avoid excessive source printing for widely-separated locations

2016-02-09 Thread Thomas Koenig
[In reply to https://gcc.gnu.org/ml/gcc-patches/2016-02/msg00646.html ] Hi David, > OK for trunk in stage 4? (PR 69554 is a regression) The Fortran part of the patch is OK. I would also appreciate if the patch could go in. The chances of encountering this regression in Fortran are rather