RE: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-06 Thread Tamar Christina via Gcc-patches
> Hi! > > On Sun, Mar 05, 2023 at 03:33:40PM -0600, Segher Boessenkool wrote: > > On Sun, Mar 05, 2023 at 08:43:20PM +, Tamar Christina wrote: > > Yes, *look* better: I have seen no proof or indication that this would > > ("looks", I cannot type, sorry) > > > actually generate better code,

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-06 Thread Segher Boessenkool
Hi! On Sun, Mar 05, 2023 at 03:33:40PM -0600, Segher Boessenkool wrote: > On Sun, Mar 05, 2023 at 08:43:20PM +, Tamar Christina wrote: > Yes, *look* better: I have seen no proof or indication that this would ("looks", I cannot type, sorry) > actually generate better code, not even on just

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Segher Boessenkool
Hi! On Sun, Mar 05, 2023 at 08:43:20PM +, Tamar Christina wrote: > > On 3/5/23 12:28, Tamar Christina via Gcc-patches wrote: > > > The regression was reported during stage-1. A patch was provided during > > stage 1 and the discussions around combine stalled. > > > > > > The regression for

RE: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Tamar Christina via Gcc-patches
> > On 3/5/23 12:28, Tamar Christina via Gcc-patches wrote: > > > > The regression was reported during stage-1. A patch was provided during > stage 1 and the discussions around combine stalled. > > > > The regression for AArch64 needs to be fixed in GCC 13. The hit is too big > > just > to

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Jeff Law via Gcc-patches
On 3/5/23 12:28, Tamar Christina via Gcc-patches wrote: The regression was reported during stage-1. A patch was provided during stage 1 and the discussions around combine stalled. The regression for AArch64 needs to be fixed in GCC 13. The hit is too big just to "take". So we need a way

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Tamar Christina via Gcc-patches
nks, Tamar From: Segher Boessenkool Sent: Saturday, March 4, 2023 10:17 PM To: Roger Sayle Cc: 'GCC Patches' ; Tamar Christina ; Richard Sandiford Subject: Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap. On Sat, Mar 04, 2023 at 06:32:

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-04 Thread Segher Boessenkool
On Sat, Mar 04, 2023 at 06:32:15PM -, Roger Sayle wrote: > This patch addresses PR rtl-optimization/106594, a P1 performance > regression affecting aarch64. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check, both with and without

[PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-04 Thread Roger Sayle
This patch addresses PR rtl-optimization/106594, a P1 performance regression affecting aarch64. This patch has been tested on x86_64-pc-linux-gnu with make bootstrap and make -k check, both with and without --target_board=unix{-m32}, with no new failures. If someone (who can regression test this