[PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2011-12-15 Thread Patrick Marlier
In PR51280, LTO does ICE because the object file uses TM builtin but the TM is not enabled. In the patch, it displays a error message if the builtin is not defined and due to TM. I moved is_tm_builtin() from calls.c to trans-mem.c. I splitted it into 2 functions is_tm_builtin/is_tm_builtin_code.

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2011-12-16 Thread Richard Guenther
On Thu, 15 Dec 2011, Patrick Marlier wrote: > In PR51280, LTO does ICE because the object file uses TM builtin but the TM is > not enabled. > In the patch, it displays a error message if the builtin is not defined and > due to TM. > I moved is_tm_builtin() from calls.c to trans-mem.c. I splitted i

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2011-12-19 Thread Patrick Marlier
On 12/16/2011 03:54 AM, Richard Guenther wrote: On Thu, 15 Dec 2011, Patrick Marlier wrote: In PR51280, LTO does ICE because the object file uses TM builtin but the TM is not enabled. In the patch, it displays a error message if the builtin is not defined and due to TM. I moved is_tm_builtin()

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2011-12-20 Thread Richard Guenther
On Mon, 19 Dec 2011, Patrick Marlier wrote: > On 12/16/2011 03:54 AM, Richard Guenther wrote: > > On Thu, 15 Dec 2011, Patrick Marlier wrote: > > > > > In PR51280, LTO does ICE because the object file uses TM builtin but the > > > TM is > > > not enabled. > > > In the patch, it displays a error m

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-17 Thread Aldy Hernandez
On 12/20/11 03:43, Richard Guenther wrote: On Mon, 19 Dec 2011, Patrick Marlier wrote: On 12/16/2011 03:54 AM, Richard Guenther wrote: On Thu, 15 Dec 2011, Patrick Marlier wrote: In PR51280, LTO does ICE because the object file uses TM builtin but the TM is not enabled. In the patch, it disp

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-17 Thread Richard Guenther
On Tue, 17 Jan 2012, Aldy Hernandez wrote: > On 12/20/11 03:43, Richard Guenther wrote: > > On Mon, 19 Dec 2011, Patrick Marlier wrote: > > > > > On 12/16/2011 03:54 AM, Richard Guenther wrote: > > > > On Thu, 15 Dec 2011, Patrick Marlier wrote: > > > > > > > > > In PR51280, LTO does ICE because

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-17 Thread Aldy Hernandez
What I have in mind is to abstract out the initialization of TM builtins from gtm-builtins.def (through its inclusion in builtins.def) into a separate function that we can call either in c_define_builtins() from the C-ish front-ends, or from lto_define_builtins (once we encounter a TM builtin an

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-18 Thread Richard Guenther
On Tue, 17 Jan 2012, Aldy Hernandez wrote: > > > > What I have in mind is to abstract out the initialization of TM builtins > > > from > > > gtm-builtins.def (through its inclusion in builtins.def) into a separate > > > function that we can call either in c_define_builtins() from the C-ish > > >

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-18 Thread Aldy Hernandez
On 01/18/12 03:09, Richard Guenther wrote: On Tue, 17 Jan 2012, Aldy Hernandez wrote: What I have in mind is to abstract out the initialization of TM builtins from gtm-builtins.def (through its inclusion in builtins.def) into a separate function that we can call either in c_define_builtins()

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-19 Thread Richard Guenther
On Wed, 18 Jan 2012, Aldy Hernandez wrote: > On 01/18/12 03:09, Richard Guenther wrote: > > On Tue, 17 Jan 2012, Aldy Hernandez wrote: > > > > > > > > > > What I have in mind is to abstract out the initialization of TM > > > > > builtins > > > > > from > > > > > gtm-builtins.def (through its inc

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-20 Thread Dominique Dhumieres
> The following patch fixes the problem. The test fails on *-apple-darwin*: pr51916. TIA Dominique

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-21 Thread Patrick Marlier
On 01/20/2012 08:04 AM, Dominique Dhumieres wrote: The following patch fixes the problem. The test fails on *-apple-darwin*: pr51916. TIA Dominique Dominique or Iain, may I ask you to test this patch on darwin? I have a sporadic access to a darwin machine. Bootstrapped and tested on x86_

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-21 Thread Patrick Marlier
On 01/20/2012 08:04 AM, Dominique Dhumieres wrote: The following patch fixes the problem. The test fails on *-apple-darwin*: pr51916. TIA Dominique Dominique or Iain, may I ask you to test this patch on darwin? I have a sporadic access to a darwin machine. Bootstrapped and tested on x86_

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-22 Thread Dominique Dhumieres
> Dominique or Iain, may I ask you to test this patch on darwin? I have a > sporadic access to a darwin machine. The patch fixes the PR without regression on x86_64-apple-darwin10. Bootstraping on powerpc-apple-darwin9 will finish in a couple hours. Thanks for the debugging and the patch, Domini

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-22 Thread Iain Sandoe
Hi Patrick, thanks for doing this, On 21 Jan 2012, at 22:57, Patrick Marlier wrote: Dominique or Iain, may I ask you to test this patch on darwin? I have a sporadic access to a darwin machine. bootstrapped on i686-darwin9 - tests in progress... minor observations: PR lto/51916

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-23 Thread Aldy Hernandez
PR lto/51916 * lto-object.c (LTO_SEGMENT_NAME): Define segment name. (lto_obj_file_open): Use it. Patrick, the changelog was referring to the wrong file and the wrong function. I've fixed it. I also inlined the segment name, as Ian had in the PR. Richard Guenther approved the patch on th