Re: [PATCH] Prevent cselib substitution of FP, SP, SFP

2012-09-17 Thread Ahmad Sharif
On Fri, Sep 14, 2012 at 9:39 AM, Carrot Wei wrote: > > Hi Jakub > > I have run it on 4.6, it passes the following testing: > > x86-64 bootstrap > x86-64 regression test > regression test on arm qemu > > Is it OK for gcc4.6? > > Ahmad, is it OK for google/gcc-4_6/ and google/gcc-4_6-mobile ? Yes,

Re: [PATCH] Prevent cselib substitution of FP, SP, SFP

2012-09-14 Thread Jakub Jelinek
On Fri, Sep 14, 2012 at 09:39:43AM -0700, Carrot Wei wrote: > I have run it on 4.6, it passes the following testing: > > x86-64 bootstrap > x86-64 regression test > regression test on arm qemu > > Is it OK for gcc4.6? Yes. Jakub

Re: [PATCH] Prevent cselib substitution of FP, SP, SFP

2012-09-14 Thread Carrot Wei
Hi Jakub I have run it on 4.6, it passes the following testing: x86-64 bootstrap x86-64 regression test regression test on arm qemu Is it OK for gcc4.6? Ahmad, is it OK for google/gcc-4_6/ and google/gcc-4_6-mobile ? thanks Carrot On Wed, Sep 12, 2012 at 2:01 PM, Carrot Wei wrote: > Hi Jakub

Re: [PATCH] Prevent cselib substitution of FP, SP, SFP

2012-09-12 Thread Carrot Wei
Hi Jakub The same problem also affects gcc4.6, http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54398. Could this be ported to 4.6 branch? thanks Carrot On Mon, Feb 13, 2012 at 11:54 AM, Jakub Jelinek wrote: > > On Wed, Jan 04, 2012 at 05:21:38PM +, Marcus Shawcroft wrote: > > Alias analysis by

Re: [PATCH] Prevent cselib substitution of FP, SP, SFP

2012-02-13 Thread Richard Henderson
On 02/13/2012 11:54 AM, Jakub Jelinek wrote: > * cselib.c (expand_loc): Return sp, fp, hfp or cfa base reg right > away if seen. Looks good. r~

Re: [PATCH] Prevent cselib substitution of FP, SP, SFP

2012-02-13 Thread Jakub Jelinek
On Wed, Jan 04, 2012 at 05:21:38PM +, Marcus Shawcroft wrote: > Alias analysis by DSE based on CSELIB expansion assumes that > references to the stack frame from different base registers (ie FP, SP) > never alias. > > The comment block in cselib explains that cselib does not allow > substituti

[PATCH] Prevent cselib substitution of FP, SP, SFP

2012-01-04 Thread Marcus Shawcroft
Alias analysis by DSE based on CSELIB expansion assumes that references to the stack frame from different base registers (ie FP, SP) never alias. The comment block in cselib explains that cselib does not allow substitution of FP, SP or SFP specifically in order not to break DSE. However, the log