Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-04-27 Thread Jason Merrill
On 04/27/2012 07:56 AM, Martin Jambor wrote: PR lto/53138 * dwarf2out.c (dwarf2out_decl): Only lookup die representing context of a variable when the contect is a function. OK. Jason

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-04-27 Thread Martin Jambor
Hi, I'd like to drag some attention to this bug again, it is the only ICE when LTO building Firefox with debug info and the problem also happens with the 4.7 so it would be nice to have this fixed for 4.7.1. On Mon, Mar 12, 2012 at 11:51:05AM +0100, Richard Guenther wrote: > On Thu, Mar 8, 2012 a

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-16 Thread Martin Jambor
Hi, On Fri, Mar 16, 2012 at 05:14:38PM +0100, Martin Jambor wrote: > On Mon, Mar 12, 2012 at 11:51:05AM +0100, Richard Guenther wrote: > > On Thu, Mar 8, 2012 at 12:18 PM, Jakub Jelinek wrote: > > > On Thu, Mar 08, 2012 at 12:06:46PM +0100, Martin Jambor wrote: > > >>        /* For local statics

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-16 Thread Martin Jambor
Hi, On Mon, Mar 12, 2012 at 11:51:05AM +0100, Richard Guenther wrote: > On Thu, Mar 8, 2012 at 12:18 PM, Jakub Jelinek wrote: > > On Thu, Mar 08, 2012 at 12:06:46PM +0100, Martin Jambor wrote: > >>        /* For local statics lookup proper context die.  */ > >> -      if (TREE_STATIC (decl) && de

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-12 Thread Richard Guenther
On Thu, Mar 8, 2012 at 12:18 PM, Jakub Jelinek wrote: > On Thu, Mar 08, 2012 at 12:06:46PM +0100, Martin Jambor wrote: >>        /* For local statics lookup proper context die.  */ >> -      if (TREE_STATIC (decl) && decl_function_context (decl)) >> -     context_die = lookup_decl_die (DECL_CONTEX

Re: [PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-08 Thread Jakub Jelinek
On Thu, Mar 08, 2012 at 12:06:46PM +0100, Martin Jambor wrote: >/* For local statics lookup proper context die. */ > - if (TREE_STATIC (decl) && decl_function_context (decl)) > - context_die = lookup_decl_die (DECL_CONTEXT (decl)); > + if (TREE_STATIC (decl) && > + (ctx

[PATCH] Proper use of decl_function_context in dwar2out.c

2012-03-08 Thread Martin Jambor
Hi, the following patch fixes an ICE for me when LTO building Firefox at -O3 -g. The problem is that at one spot we use decl_function_context as a predicate whether to use TREE_CONTEXT rather than using it's result which can be determined in a much more elaborate way. In my particular case TREE_