Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-25 Thread Alan Lawrence
s/tiny/small/ and I think we might be getting close. So the 403.gcc test being compiled contains: if (regno == PIC_OFFSET_TABLE_REGNUM fixed_regs[PIC_OFFSET_TABLE_REGNUM]) return pic_offset_table_rtx; PIC_OFFSET_TABLE_REGNUM is an expression testing machine flags; prior to

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-22 Thread Alan Lawrence
Well, I haven't looked into this in detail: I've gone only as far as * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' compiles (r214043), finding that the critical difference is in the emit-rtl.o generated by r214043; *looking at the relocations in the 'bad' emit_rtl.o,

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 1:10 PM, Alan Lawrence alan.lawre...@arm.com wrote: Well, I haven't looked into this in detail: I've gone only as far as * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' compiles (r214043), finding that the critical difference is in the emit-rtl.o

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-22 Thread Andrew Pinski
On Mon, Sep 22, 2014 at 4:10 AM, Alan Lawrence alan.lawre...@arm.com wrote: Well, I haven't looked into this in detail: I've gone only as far as * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' compiles (r214043), finding that the critical difference is in the emit-rtl.o

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-18 Thread Alan Lawrence
We've been seeing errors using aarch64-none-linux-gnu gcc to build the 403.gcc benchmark from spec2k6, that we've traced back to this patch. The error looks like: /home/alalaw01/bootstrap_richie/gcc/xgcc -B/home/alalaw01/bootstrap_richie/gcc -O3 -mcpu=cortex-a57.cortex-a53 -DSPEC_CPU_LP64

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-18 Thread Andrew Pinski
On Thu, Sep 18, 2014 at 9:44 AM, Alan Lawrence alan.lawre...@arm.com wrote: We've been seeing errors using aarch64-none-linux-gnu gcc to build the 403.gcc benchmark from spec2k6, that we've traced back to this patch. The error looks like: /home/alalaw01/bootstrap_richie/gcc/xgcc

[PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-08-15 Thread Richard Biener
The following makes tree_swap_operands_p put all constants 2nd place, also looks through sign-changes when considering further canonicalzations and removes the odd -Os guard for those. That was put in with https://gcc.gnu.org/ml/gcc-patches/2003-10/msg01208.html just motivated by CSiBE numbers -

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-08-15 Thread Manuel López-Ibáñez
On 15 August 2014 11:07, Richard Biener rguent...@suse.de wrote: - if (TREE_CODE (arg1) == INTEGER_CST) + if (CONSTANT_CLASS_P (arg1) == INTEGER_CST) Huh? /* Nonzero if NODE represents a constant. */ #define CONSTANT_CLASS_P(NODE)\ (TREE_CODE_CLASS (TREE_CODE (NODE)) == tcc_constant)

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-08-15 Thread Richard Biener
On Fri, 15 Aug 2014, Manuel López-Ibáñez wrote: On 15 August 2014 11:07, Richard Biener rguent...@suse.de wrote: - if (TREE_CODE (arg1) == INTEGER_CST) + if (CONSTANT_CLASS_P (arg1) == INTEGER_CST) Huh? Eh ;) /* Nonzero if NODE represents a constant. */ #define

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-08-15 Thread Franz Sirl
Am 15.08.2014 um 11:32 schrieb Manuel López-Ibáñez: On 15 August 2014 11:07, Richard Biener rguent...@suse.de wrote: - if (TREE_CODE (arg1) == INTEGER_CST) + if (CONSTANT_CLASS_P (arg1) == INTEGER_CST) Huh? /* Nonzero if NODE represents a constant. */ #define CONSTANT_CLASS_P(NODE)\

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-08-15 Thread Manuel López-Ibáñez
On 15 August 2014 14:43, Franz Sirl franz.sirl-ker...@lauterbach.com wrote: Am 15.08.2014 um 11:32 schrieb Manuel López-Ibáñez: On 15 August 2014 11:07, Richard Biener rguent...@suse.de wrote: - if (TREE_CODE (arg1) == INTEGER_CST) + if (CONSTANT_CLASS_P (arg1) == INTEGER_CST) Huh? /*