Re: [PATCH] RISC-V: Add pattern for vector-scalar floating-point min

2025-08-28 Thread Paul-Antoine Arras
On 28/08/2025 14:19, Robin Dapp wrote: LGTM.  Are the IEEE-min/max variants in your plans as well? I haven't checked if we propagate into those at all (unspec), though. Yes, the IEEE variants are coming up next. Thanks, -- PA

Re: [PATCH] RISC-V: Add pattern for vector-scalar floating-point min

2025-08-28 Thread Paul-Antoine Arras
On 28/08/2025 17:23, Kito Cheng wrote: +  [(set_attr "type" "vfmuladd")] this seems incorrect, otherwise LGTM Good catch! It should be "vfminmax" -- copy-paste mistake. Thanks, -- PA

Re: [PATCH] RISC-V: Add pattern for vector-scalar floating-point min

2025-08-28 Thread Kito Cheng
Paul-Antoine Arras 於 2025年8月28日 週四,01:50寫道: > This pattern enables the combine pass (or late-combine, depending on the > case) > to merge a vec_duplicate into an smin RTL instruction. > > Before this patch, we have two instructions, e.g.: > vfmv.v.f v2,fa0 > vfmin.vv v1,v1,v2 > > A

Re: [PATCH] RISC-V: Add pattern for vector-scalar floating-point min

2025-08-28 Thread Robin Dapp
LGTM. Are the IEEE-min/max variants in your plans as well? I haven't checked if we propagate into those at all (unspec), though. -- Regards Robin

[PATCH] RISC-V: Add pattern for vector-scalar floating-point min

2025-08-27 Thread Paul-Antoine Arras
This pattern enables the combine pass (or late-combine, depending on the case) to merge a vec_duplicate into an smin RTL instruction. Before this patch, we have two instructions, e.g.: vfmv.v.f v2,fa0 vfmin.vv v1,v1,v2 After, we get only one: vfmin.vf v1,v1,fa0 gcc/Change