RE: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

2023-05-29 Thread Li, Pan2 via Gcc-patches
Committed, thanks Kito. Pan -Original Message- From: Li, Pan2 Sent: Monday, May 29, 2023 1:38 PM To: Kito Cheng Cc: Robin Dapp ; gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang Subject: RE: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

RE: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

2023-05-28 Thread Li, Pan2 via Gcc-patches
: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc LGTM On Fri, May 26, 2023 at 2:32 PM Li, Pan2 via Gcc-patches wrote: > > Thanks Robin. > > Sorry for not mentioned that it depends on another patch > https://gcc.gnu.org/pipermail/gcc-patches/2023-May/619536.html, which is in

Re: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

2023-05-28 Thread Kito Cheng via Gcc-patches
> Sent: Friday, May 26, 2023 2:24 PM > To: Li, Pan2 ; gcc-patches@gcc.gnu.org > Cc: rdapp@gmail.com; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, > Yanzhang > Subject: Re: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc > > Hi, > > > This patch woul

RE: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

2023-05-25 Thread Li, Pan2 via Gcc-patches
; Wang, Yanzhang Subject: Re: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc Hi, > This patch would like to remove the magic number in the riscv-v.cc, > and align the same value to one macro. > diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc

Re: [PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

2023-05-25 Thread Robin Dapp via Gcc-patches
Hi, > This patch would like to remove the magic number in the riscv-v.cc, and > align the same value to one macro. > diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc > index 458020ce0a1..20b589bf51b 100644 > --- a/gcc/config/riscv/riscv-v.cc > +++ b/gcc/config/riscv/riscv-v.

[PATCH] RISC-V: Eliminate the magic number in riscv-v.cc

2023-05-25 Thread Pan Li via Gcc-patches
From: Pan Li This patch would like to remove the magic number in the riscv-v.cc, and align the same value to one macro. Signed-off-by: Pan Li gcc/ChangeLog: * config/riscv/riscv-v.cc (emit_vlmax_insn): Eliminate the magic number. (emit_nonvlmax_insn): Ditto. (e