On 12/14/23 04:12, Liao Shihua wrote:
Sorry, I was not aware of this patch.
Since Jeff's patch was here first and also includes more tests, I
propose to move forward with his patch (but I'm not a maintainer!).
Therefore, I've reviewed Jeff's patch and replied to his email.
FWIW: Jeff's patch
On 12/14/23 02:48, Christoph Müllner wrote:
On Thu, Dec 14, 2023 at 1:40 AM Jeff Law wrote:
On 12/13/23 02:03, Christoph Müllner wrote:
On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote:
In Scalar Crypto Built-In functions, some require immediate parameters,
But register_operand are
On 12/14/23 02:48, Christoph Müllner wrote:
On Thu, Dec 14, 2023 at 1:40 AM Jeff Law wrote:
On 12/13/23 02:03, Christoph Müllner wrote:
On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote:
In Scalar Crypto Built-In functions, some require immediate parameters,
But register_operand are
Sorry, I was not aware of this patch.
Since Jeff's patch was here first and also includes more tests, I
propose to move forward with his patch (but I'm not a maintainer!).
Therefore, I've reviewed Jeff's patch and replied to his email.
FWIW: Jeff's patch can be found here:
On Thu, Dec 14, 2023 at 1:40 AM Jeff Law wrote:
> On 12/13/23 02:03, Christoph Müllner wrote:
> > On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote:
> >>
> >> In Scalar Crypto Built-In functions, some require immediate parameters,
> >> But register_operand are incorrectly used in the pattern.
>
On 12/13/23 02:03, Christoph Müllner wrote:
On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote:
In Scalar Crypto Built-In functions, some require immediate parameters,
But register_operand are incorrectly used in the pattern.
E.g.:
__builtin_riscv_aes64ks1i(rs1,1)
Before:
li
On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote:
>
> In Scalar Crypto Built-In functions, some require immediate parameters,
> But register_operand are incorrectly used in the pattern.
>
> E.g.:
>__builtin_riscv_aes64ks1i(rs1,1)
>Before:
> li a5,1
> aes64ks1i a0,a0,a5
>
>
In Scalar Crypto Built-In functions, some require immediate parameters,
But register_operand are incorrectly used in the pattern.
E.g.:
__builtin_riscv_aes64ks1i(rs1,1)
Before:
li a5,1
aes64ks1i a0,a0,a5
Assembler messages:
Error: instruction aes64ks1i
