Re: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Jakub Jelinek
On Mon, Feb 12, 2018 at 01:36:54PM +, Sebastian Perta wrote: > Hi Jakub, > > >>Still missing . at the end of the above line. > > The sentence continues on the next line (so the "." is there): > > +* config/rx/constraints.md (CALL_OP_SYMBOL_REF): Added new constraint > +to allow or block "sym

Re: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Jakub Jelinek
On Mon, Feb 12, 2018 at 01:27:24PM -, Sebastian Perta wrote: > --- ChangeLog (revision 257583) > +++ ChangeLog (working copy) > @@ -129,8 +129,7 @@ > > 2018-02-09 Sebastian Perta > > - * config/rx.md: updated "movsicc" expand to be matched by GCC > - * testsuite/gcc.target/rx/mo

RE: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Sebastian Perta
I think this is OK, please confirm. Best Regards, Sebastian > -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: 12 February 2018 13:30 > To: Sebastian Perta > Cc: Nick Clifton ; gcc-patches patc...@gcc.gnu.org> > Subject: Re: PING [PATCH] RX mov

RE: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Sebastian Perta
get/powerpc/safe-indirect-jump-1.c: Build on all targets. > -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: 12 February 2018 12:45 > To: Sebastian Perta > Cc: Nick Clifton ; gcc-patches patc...@gcc.gnu.org> > Subject: Re: PING [PATCH] RX movsicc

Re: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Jakub Jelinek
On Mon, Feb 12, 2018 at 11:06:35AM -, Sebastian Perta wrote: > Hi Jakub, > > Thank you for pointing this out, I'm sorry! > Can I create a patch to correct the changelog entries? > > Best Regards, > Sebastian > > >>1) there should be a space between * and the filename > The spaces are there

Re: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Oleg Endo
On Mon, 2018-02-12 at 11:06 +, Sebastian Perta wrote: > > > 1) there should be a space between * and the filename > The spaces are there (see the changelog), the renesas mail server > removes them sometimes You might want to send around your patches as email attachments.  That avoids formatt

Re: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Jakub Jelinek
On Mon, Feb 12, 2018 at 11:06:35AM -, Sebastian Perta wrote: > Thank you for pointing this out, I'm sorry! > Can I create a patch to correct the changelog entries? Yes, and no need to add a ChangeLog entry for ChangeLog changes ;) Jakub

RE: PING [PATCH] RX movsicc degrade fix

2018-02-12 Thread Sebastian Perta
-Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: 09 February 2018 18:24 > To: Sebastian Perta ; Nick Clifton > > Cc: gcc-patches > Subject: Re: PING [PATCH] RX movsicc degrade fix > > On Wed, Feb 07, 2018 at 02:10:21PM +

Re: PING [PATCH] RX movsicc degrade fix

2018-02-07 Thread Nick Clifton
Hi Sebastian, Sorry for missing this one. If it helps in the future, feel free to ping me directly. > +2018-01-09 Sebastian Perta > + > + *config/rx.md: updated "movsicc" expand to be matched by GCC > + *testsuite/gcc.target/rx/movsicc.c: new test case Approved - please apply. Ch

PING [PATCH] RX movsicc degrade fix

2018-02-06 Thread Sebastian Perta
PING > -Original Message- > From: Sebastian Perta [mailto:sebastian.pe...@renesas.com] > Sent: 09 January 2018 14:46 > To: 'gcc-patches@gcc.gnu.org' > Subject: [PATCH] RX movsicc degrade fix > > Hello, > > In recent versions of GCC the define_expa

[PATCH] RX movsicc degrade fix

2018-01-09 Thread Sebastian Perta
Hello, In recent versions of GCC the define_expand "movsicc" has stopped being used by GCC (approx. 4.7.x/4.8.x onwards) The reason for this is that the first operand of if_then_else has SI mode and it shouldn't have. If we take a look at movsicc for all other targets we see this is true. The fix