Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-29 Thread Jeff Law
On 04/26/2015 07:09 PM, Josh Triplett wrote: handle_section_attribute contains many levels of nested conditionals and branching code flow paths, with the error cases sometimes in the else case and sometimes in the if case. Simplify the code flow into a series of potential failure cases ending wi

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-28 Thread Josh Triplett
On Tue, Apr 28, 2015 at 06:10:33PM -0600, Jeff Law wrote: > On 04/26/2015 07:09 PM, Josh Triplett wrote: > >handle_section_attribute contains many levels of nested conditionals and > >branching code flow paths, with the error cases sometimes in the else > >case and sometimes in the if case. Simpli

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-28 Thread Jeff Law
On 04/26/2015 07:09 PM, Josh Triplett wrote: handle_section_attribute contains many levels of nested conditionals and branching code flow paths, with the error cases sometimes in the else case and sometimes in the if case. Simplify the code flow into a series of potential failure cases ending wi

[PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-26 Thread Josh Triplett
handle_section_attribute contains many levels of nested conditionals and branching code flow paths, with the error cases sometimes in the else case and sometimes in the if case. Simplify the code flow into a series of potential failure cases ending with the successful path, with no nesting and no

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Josh Triplett
On Sun, Aug 24, 2014 at 05:47:23PM -0400, Trevor Saunders wrote: > On Sun, Aug 24, 2014 at 01:58:52PM -0700, Andrew Pinski wrote: > > On Sun, Aug 24, 2014 at 1:42 PM, Josh Triplett > > wrote: > > > handle_section_attribute contains many levels of nested conditionals and > > > branching code flow

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Trevor Saunders
On Sun, Aug 24, 2014 at 01:58:52PM -0700, Andrew Pinski wrote: > On Sun, Aug 24, 2014 at 1:42 PM, Josh Triplett wrote: > > handle_section_attribute contains many levels of nested conditionals and > > branching code flow paths, with the error cases sometimes in the else > > case and sometimes in th

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Josh Triplett
On Sun, Aug 24, 2014 at 01:58:52PM -0700, Andrew Pinski wrote: > On Sun, Aug 24, 2014 at 1:42 PM, Josh Triplett wrote: > > handle_section_attribute contains many levels of nested conditionals and > > branching code flow paths, with the error cases sometimes in the else > > case and sometimes in th

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Andrew Pinski
On Sun, Aug 24, 2014 at 1:42 PM, Josh Triplett wrote: > handle_section_attribute contains many levels of nested conditionals and > branching code flow paths, with the error cases sometimes in the else > case and sometimes in the if case. Simplify the code flow into a series > of potential failure

[PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Josh Triplett
handle_section_attribute contains many levels of nested conditionals and branching code flow paths, with the error cases sometimes in the else case and sometimes in the if case. Simplify the code flow into a series of potential failure cases ending with the successful path, with no nesting and no