Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-19 Thread Martin Liška
On 11/19/21 15:06, Richard Biener wrote: Can you please revert it? Sure, done as 79e9f721d1a6f370ce0534745baeeb5a56da948e. Martin

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-19 Thread Richard Biener via Gcc-patches
On Fri, Nov 19, 2021 at 2:22 PM Martin Liška wrote: > > On 11/19/21 09:59, Alexandre Oliva wrote: > > So I find the abstraction useful. However, I don't have plans to add > > other kinds of debug stmts, and I don't know of anyone else who does, so > > I won't stand in the way if others think

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-19 Thread Martin Liška
On 11/19/21 09:59, Alexandre Oliva wrote: So I find the abstraction useful. However, I don't have plans to add other kinds of debug stmts, and I don't know of anyone else who does, so I won't stand in the way if others think removing these abstractions is a positive change. Hello. I've

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-19 Thread Jakub Jelinek via Gcc-patches
On Fri, Nov 19, 2021 at 10:38:41AM +0100, Richard Biener via Gcc-patches wrote: > > Yup. Though there is a 1:1 equivalence right now, conceptually other > > kinds of debug marker stmts, and of debug bind stmts, could be > > introduced, and then the macros would be adjusted to encompass the new >

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-19 Thread Richard Biener via Gcc-patches
On Fri, Nov 19, 2021 at 9:59 AM Alexandre Oliva wrote: > > On Oct 18, 2021, Richard Biener via Gcc-patches > wrote: > > > On Mon, Oct 18, 2021 at 10:54 AM Martin Liška wrote: > >> > >> The macros correspond 1:1 to an option flags and make it harder > >> to find all usages of the flags. > >> >

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-19 Thread Alexandre Oliva via Gcc-patches
On Oct 18, 2021, Richard Biener via Gcc-patches wrote: > On Mon, Oct 18, 2021 at 10:54 AM Martin Liška wrote: >> >> The macros correspond 1:1 to an option flags and make it harder >> to find all usages of the flags. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-15 Thread Jeff Law via Gcc-patches
On 11/12/2021 7:37 AM, Martin Liška wrote: @Alexandre: PING On 10/18/21 12:05, Richard Biener wrote: On Mon, Oct 18, 2021 at 10:54 AM Martin Liška wrote: The macros correspond 1:1 to an option flags and make it harder to find all usages of the flags. Patch can bootstrap on

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-11-12 Thread Martin Liška
@Alexandre: PING On 10/18/21 12:05, Richard Biener wrote: On Mon, Oct 18, 2021 at 10:54 AM Martin Liška wrote: The macros correspond 1:1 to an option flags and make it harder to find all usages of the flags. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be

Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-10-18 Thread Richard Biener via Gcc-patches
On Mon, Oct 18, 2021 at 10:54 AM Martin Liška wrote: > > The macros correspond 1:1 to an option flags and make it harder > to find all usages of the flags. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Hmm, they were introduced on purpose -

[PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-10-18 Thread Martin Liška
The macros correspond 1:1 to an option flags and make it harder to find all usages of the flags. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/c-family/ChangeLog: * c-gimplify.c (genericize_c_loop): Use option