Re: [PATCH] Remove dead code in asan.c

2017-06-30 Thread Jakub Jelinek
> + /* Unpoison shadow memory that corresponds to a variable that was > + is subject of use-after-return sanitization. */ was is ? And shouldn't it be subject to instead of subject of? Otherwise LGTM. Jakub

Re: [PATCH] Remove dead code in asan.c

2017-06-30 Thread Martin Liška
On 06/30/2017 12:15 PM, Jakub Jelinek wrote: > On Fri, Jun 30, 2017 at 12:00:36PM +0200, Martin Liška wrote: >> Hi. >> >> Following crap code was added by me when I added use-after-scope. >> Actually decl always points to LASANPC, so asan_handled_variables->contains >> (decl) >> is always false.

Re: [PATCH] Remove dead code in asan.c

2017-06-30 Thread Jakub Jelinek
On Fri, Jun 30, 2017 at 12:00:36PM +0200, Martin Liška wrote: > Hi. > > Following crap code was added by me when I added use-after-scope. > Actually decl always points to LASANPC, so asan_handled_variables->contains > (decl) > is always false. > > Well, originally the idea was to not clear

[PATCH] Remove dead code in asan.c

2017-06-30 Thread Martin Liška
Hi. Following crap code was added by me when I added use-after-scope. Actually decl always points to LASANPC, so asan_handled_variables->contains (decl) is always false. Well, originally the idea was to not clear content (place in shadow memory in between red zoner) of auto variables, but as