Re: [PATCH] Remove restriction for remote testing

2015-10-07 Thread James Norris
Hi, On 10/05/2015 01:56 PM, Mike Stump wrote: I don't think this is appropriate. The design is for remote host testing to have the compete shape of an installed compiler as I recall. When it does, it then is indistinguishable from an installed compiler, and when it is installed, then no

Re: [PATCH] Remove restriction for remote testing

2015-10-07 Thread Mike Stump
On Oct 7, 2015, at 6:08 AM, James Norris wrote: > I've revised the patch based on the review comments from yourself, > Bernd, and Joseph (thank you for your comments). > OK? Ok.

Re: [PATCH] Remove restriction for remote testing

2015-10-05 Thread Mike Stump
On Sep 28, 2015, at 5:35 AM, James Norris wrote: > The attached patch fixes a problem when doing remote testing. > Specifically, testing of the atomic tests found in gcc/atomic. > The code in atomic_init precludes the setting of the variable > 'link_flags' when doing

Re: [PATCH] Remove restriction for remote testing

2015-10-05 Thread Joseph Myers
On Mon, 5 Oct 2015, Mike Stump wrote: > or otherwise unconditionally put -latomic on the link line (some place > that isn’t protected by is_remote host). Remembering of course that it needs to be done in a way that doesn't leave it there for other .exp files executed after atomic.exp. --

Re: [PATCH] Remove restriction for remote testing

2015-10-05 Thread Bernd Schmidt
On 10/05/2015 02:00 PM, James Norris wrote: Ping. As I said previously, I think appending "-latomic" unconditionally in atomic_init is probably a better solution because I'm not convinced that the things atomic_link_flags does are appropriate in a remote host situation. Bernd

Re: [PATCH] Remove restriction for remote testing

2015-10-05 Thread James Norris
Ping. On 09/28/2015 07:35 AM, James Norris wrote: Hi, The attached patch fixes a problem when doing remote testing. Specifically, testing of the atomic tests found in gcc/atomic. The code in atomic_init precludes the setting of the variable 'link_flags' when doing remote testing. The

Re: [PATCH] Remove restriction for remote testing

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 02:35 PM, James Norris wrote: The attached patch fixes a problem when doing remote testing. Specifically, testing of the atomic tests found in gcc/atomic. The code in atomic_init precludes the setting of the variable 'link_flags' when doing remote testing. The conditional test can

[PATCH] Remove restriction for remote testing

2015-09-28 Thread James Norris
Hi, The attached patch fixes a problem when doing remote testing. Specifically, testing of the atomic tests found in gcc/atomic. The code in atomic_init precludes the setting of the variable 'link_flags' when doing remote testing. The conditional test can be safely removed as get_multilibs will