Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Joseph Myers
On Fri, 25 Oct 2024, Arsen Arsenović wrote: > Maybe we should go the other way around? Compressing eight spaces into > a tab leads to strange artifacts in diffs (where lines appear > misindented because some were aligned by tabs and some by spaces), and I also agree that spaces are preferable (g

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Arsen Arsenović
Sam James writes: > IMO these (already-committed other) whitespace changes mean we should > already consider a .git-blame-ignore-revs file at the root of the repo. > > We would list any large whitespace changes in there. > > Users would have to run 'git config blame.ignoreRevsFile > .git-blame-ig

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Arsen Arsenović
Jakub Jelinek writes: > On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote: >> Maybe we should go the other way around? Compressing eight spaces into >> a tab leads to strange artifacts in diffs (where lines appear >> misindented because some were aligned by tabs and some by spaces)

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Arsen Arsenović
Jonathan Wakely writes: > On Fri, 25 Oct 2024 at 12:54, Jakub Jelinek wrote: >> >> On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote: >> > Maybe we should go the other way around? Compressing eight spaces into >> > a tab leads to strange artifacts in diffs (where lines appear >> >

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Richard Sandiford
Arsen Arsenović writes: > Hi! > > Jakub Jelinek writes: > >> Hi! >> >> On top of the previously posted leading whitespace patch, this change >> just replaces 8 consecutive spaces in leading whitespace by tab. >> The patch is too large (1MB xz -9e compressed), so I'm not even trying to >> split it

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Sam James
Jakub Jelinek writes: > On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote: >> Maybe we should go the other way around? Compressing eight spaces into >> a tab leads to strange artifacts in diffs (where lines appear >> misindented because some were aligned by tabs and some by spaces)

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Jonathan Wakely
On Fri, 25 Oct 2024 at 12:17, Jakub Jelinek wrote: > > Hi! > > On top of the previously posted leading whitespace patch, this change > just replaces 8 consecutive spaces in leading whitespace by tab. > The patch is too large (1MB xz -9e compressed), so I'm not even trying to > split it up into 4+

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Patrick Palka
On Fri, Oct 25, 2024 at 7:54 AM Jakub Jelinek wrote: > > On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote: > > Maybe we should go the other way around? Compressing eight spaces into > > a tab leads to strange artifacts in diffs (where lines appear > > misindented because some were

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Jakub Jelinek
On Fri, Oct 25, 2024 at 01:12:15PM +0100, Jonathan Wakely wrote: > So everything except: > > include/pstl/* > src/c++17/ryu/* > src/c++17/fast_float/* Thanks, changed in my copy. grep 'pstl\|ryu\|fast_float' Q624 is now empty. Jakub

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Jonathan Wakely
On Fri, 25 Oct 2024 at 12:54, Jakub Jelinek wrote: > > On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote: > > Maybe we should go the other way around? Compressing eight spaces into > > a tab leads to strange artifacts in diffs (where lines appear > > misindented because some were al

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Jakub Jelinek
On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote: > Maybe we should go the other way around? Compressing eight spaces into > a tab leads to strange artifacts in diffs (where lines appear > misindented because some were aligned by tabs and some by spaces), and > nowadays editor autho

Re: [PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Arsen Arsenović
Hi! Jakub Jelinek writes: > Hi! > > On top of the previously posted leading whitespace patch, this change > just replaces 8 consecutive spaces in leading whitespace by tab. > The patch is too large (1MB xz -9e compressed), so I'm not even trying to > split it up into 4+ pieces to fit under the m

[PATCH] Replace 8 consecutive spaces in leading whitespace by tab

2024-10-25 Thread Jakub Jelinek
Hi! On top of the previously posted leading whitespace patch, this change just replaces 8 consecutive spaces in leading whitespace by tab. The patch is too large (1MB xz -9e compressed), so I'm not even trying to split it up into 4+ pieces to fit under the mailing list limits. But the change was d