Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-19 Thread Mike Stump
Thanks.

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-19 Thread Michael Meissner
I checked in your patch along with my patches into the trunk. [gcc] 2012-10-19 Michael Meissner Dominique Dhumieres * config/rs6000/rs6000-cpus.def (POWERPC_MASKS): Don't assume OPTION_MASK_STRICT_ALIGN is defined. (MASK_STRICT_ALIGN): If OPTION_MASK_STRIC

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-19 Thread Dominique Dhumieres
> > Eric and Dominique could you try it on your respective systems? Thanks in > > advance. > > It works for me, thanks. It does not for me: In file included from ../../work/gcc/config/rs6000/rs6000.c:1475:0: ../../work/gcc/config/rs6000/rs6000-cpus.def:54:0: error: "MASK_STRICT_ALIGN" redefined

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-19 Thread Eric Botcazou
> The patch builds in 32-bit on my powerpc64-linux system (which showed up > Eric's problem). I can't test the patch for Dominique's problem, since it > needs a non-linux system to show up. I verified the debug problem: > > Eric and Dominique could you try it on your respective systems? Thanks

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-18 Thread David Edelsohn
On Thu, Oct 18, 2012 at 7:06 PM, Michael Meissner wrote: > 2012-10-18 Michael Meissner > > * config/rs6000/rs6000-cpus.def (POWERPC_MASKS): Don't assume > OPTION_MASK_STRICT_ALIGN is defined. > (MASK_STRICT_ALIGN): If OPTION_MASK_STRICT_ALIGN is not defined, > d

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-18 Thread Michael Meissner
On Thu, Oct 18, 2012 at 05:35:39PM -0400, Michael Meissner wrote: > On Thu, Oct 18, 2012 at 09:08:34PM +0200, Dominique Dhumieres wrote: > > > 2012-10-17 Michael Meissner > > > > > > * config/rs6000/rs6000.opt (rs6000_isa_flags): New flag word to > > > replace target_flags that gives us 63

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-18 Thread Michael Meissner
On Thu, Oct 18, 2012 at 09:08:34PM +0200, Dominique Dhumieres wrote: > > 2012-10-17 Michael Meissner > > > > * config/rs6000/rs6000.opt (rs6000_isa_flags): New flag word to > > replace target_flags that gives us 63 possible switches. > > (x_rs6000_isa_flags): Save area for rs6000_is

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-18 Thread Mike Stump
On Oct 18, 2012, at 12:08 PM, Dominique Dhumieres wrote: > --- gcc/config/rs6000/rs6000.c2012-10-18 00:34:51.0 +0200 > +++ ../work/gcc/config/rs6000/rs6000.c2012-10-18 08:55:28.0 > +0200 > @@ -1123,6 +1123,7 @@ static const struct attribute_spec rs600 > > > #ifnd

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-18 Thread Dominique Dhumieres
> 2012-10-17 Michael Meissner > > * config/rs6000/rs6000.opt (rs6000_isa_flags): New flag word to > replace target_flags that gives us 63 possible switches. > (x_rs6000_isa_flags): Save area for rs6000_isa_flags. > (x_rs6000_isa_flags_explicit): Save area for > ... Boot

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-18 Thread Eric Botcazou
> 2012-10-17 Michael Meissner > > * config/rs6000/rs6000.opt (rs6000_isa_flags): New flag word to > replace target_flags that gives us 63 possible switches. > (x_rs6000_isa_flags): Save area for rs6000_isa_flags. > (x_rs6000_isa_flags_explicit): Save area for > rs6

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2f

2012-10-17 Thread David Edelsohn
Mike, This patch is okay with the appropriate changes to adapt to the common infrastructure improvements. We will continue to iterate on this. Are there any testcases that would be useful? A lot of other testcases use target flags, so those probably will point out problems. Thanks, David On Tu