Re: [PATCH] Simplify refactor a bit of tree-ssa-dom.c

2013-09-20 Thread Richard Biener
On Thu, Sep 19, 2013 at 2:48 PM, Jeff Law l...@redhat.com wrote: I find it amazing to look at code I wrote in the past, the occasional WTF always makes it worth it. The code to manage the temporary expression const/copies tables in tree-ssa-dom.c around jump threading looks overly

Re: [PATCH] Simplify refactor a bit of tree-ssa-dom.c

2013-09-20 Thread Jeff Law
On 09/20/2013 02:00 AM, Richard Biener wrote: diff --git a/gcc/tree-ssa-dom.c b/gcc/tree-ssa-dom.c index aac7aa4..f561386 100644 --- a/gcc/tree-ssa-dom.c +++ b/gcc/tree-ssa-dom.c @@ -1070,6 +1070,31 @@ simplify_stmt_for_jump_threading (gimple stmt, return lookup_avail_expr (stmt, false);

[PATCH] Simplify refactor a bit of tree-ssa-dom.c

2013-09-19 Thread Jeff Law
I find it amazing to look at code I wrote in the past, the occasional WTF always makes it worth it. The code to manage the temporary expression const/copies tables in tree-ssa-dom.c around jump threading looks overly convoluted. In particular the code reused an existing unwind point for