Done. -Thanks
Feng
From: Jeff Law
Sent: Monday, December 2, 2019 4:33 AM
To: Feng Xue OS; Martin Jambor; Jan Hubicka; Richard Biener
Cc: luoxhu; gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Support multi-versioning on self-recursive function
(ipa
On 11/26/19 6:44 PM, Feng Xue OS wrote:
> Hi, Richard,
>
> This patch is a not bugfix, while it is small. Martin and Honza are fine
> with it.
> But now we are in stage 3, is it ok to commit?
Yes. It was posted well in advance of the stage1->stage3 change.
Please commit it ASAP so the testers
Subject: Re: [PATCH] Support multi-versioning on self-recursive function
(ipa/92133)
> 2019-11-15 Feng Xue
>
> PR ipa/92133
> * doc/invoke.texi (ipa-cp-max-recursive-depth): Document new option.
> (ipa-cp-min-recursive-probability): Likewise.
> * para
> 2019-11-15 Feng Xue
>
> PR ipa/92133
> * doc/invoke.texi (ipa-cp-max-recursive-depth): Document new option.
> (ipa-cp-min-recursive-probability): Likewise.
> * params.opt (ipa-cp-max-recursive-depth): New.
> (ipa-cp-min-recursive-probability): Likewise.
: luoxhu; gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Support multi-versioning on self-recursive function
(ipa/92133)
Martin,
Thanks for your review. I updated the patch with your comments.
Feng
---
2019-11-15 Feng Xue
PR ipa/92133
* doc/invoke.texi (ipa-cp-max-recursive
Martin,
Thanks for your review. I updated the patch with your comments.
Feng
---
2019-11-15 Feng Xue
PR ipa/92133
* doc/invoke.texi (ipa-cp-max-recursive-depth): Document new option.
(ipa-cp-min-recursive-probability): Likewise.
* params.opt (ipa-cp-max-recu
Hi,
On Fri, Nov 15 2019, Feng Xue OS wrote:
> Honza,
>
> I made some changes: do not penalize self-recursive function, and
> add --param ipa-cp-min-recursive-probability, similar to recursive
> inline. Please review this new one.
The patch and its effect on exchange is intriguing, I only have a f
From: Feng Xue OS
Sent: Friday, November 15, 2019 11:32 PM
To: Jan Hubicka
Cc: luoxhu; gcc-patches@gcc.gnu.org; Martin Jambor
Subject: Re: [PATCH] Support multi-versioning on self-recursive function
(ipa/92133)
Honza,
I made some changes: do not
To: Feng Xue OS
Cc: luoxhu; gcc-patches@gcc.gnu.org; Martin Jambor
Subject: Re: [PATCH] Support multi-versioning on self-recursive function
(ipa/92133)
> >> Cost model used by self-recursive cloning is mainly based on existing
> >> stuffs
> >> in ipa-cp cloning, size
> >> Cost model used by self-recursive cloning is mainly based on existing
> >> stuffs
> >> in ipa-cp cloning, size growth and time benefit are considered. But since
> >> recursive cloning is a more aggressive cloning, we will actually have
> >> another
> >> problem, which is opposite to your con
>> Cost model used by self-recursive cloning is mainly based on existing stuffs
>> in ipa-cp cloning, size growth and time benefit are considered. But since
>> recursive cloning is a more aggressive cloning, we will actually have another
>> problem, which is opposite to your concern. By default, c
> Thanks for your review.
>
> > In general the patch looks good to me, but I would like Martin Jambor to
> > comment on the ipa-prop/cp interfaces. However...
>
> > +@item ipa-cp-max-recursion-depth
> > +Maximum depth of recursive cloning for self-recursive function.
> > +
>
> > ... I believe we
Thanks for your review.
> In general the patch looks good to me, but I would like Martin Jambor to
> comment on the ipa-prop/cp interfaces. However...
> +@item ipa-cp-max-recursion-depth
> +Maximum depth of recursive cloning for self-recursive function.
> +
> ... I believe we will need more care
Hi,
I think the patch generally looks reasonable
+2019-11-13 Feng Xue
+
+ PR ipa/92133
+ * doc/invoke.texi (ipa-cp-max-recursion-depth): Document new option.
+ * params.opt (ipa-cp-max-recursion-depth): New.
+ * ipa-cp.c (ipcp_lattice::add_value): Add two new parameters
+
, October 24, 2019 1:44 PM
To: Feng Xue OS; gcc-patches@gcc.gnu.org; Jan Hubicka; Martin Jambor
Subject: Re: [PATCH] Support multi-versioning on self-recursive function
(ipa/92133)
Hi,
On 2019/10/17 16:23, Feng Xue OS wrote:
> IPA does not allow constant propagation on parameter that is used to cont
Hi,
On 2019/10/17 16:23, Feng Xue OS wrote:
> IPA does not allow constant propagation on parameter that is used to control
> function recursion.
>
> recur_fn (i)
> {
>if ( !terminate_recursion (i))
> {
>...
>recur_fn (i + 1);
>...
> }
>...
> }
>
> This
> I noticed similar issue when analyzing the SPEC, self-recursive function is
> not versioned and posted my observations in
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92074.
> Generally, this could be implemented well by your patch, while I am
> wondering whether it is OK to convert the recur
Hi Feng,
On 2019/10/17 16:23, Feng Xue OS wrote:
> IPA does not allow constant propagation on parameter that is used to control
> function recursion.
>
> recur_fn (i)
> {
>if ( !terminate_recursion (i))
> {
>...
>recur_fn (i + 1);
>...
> }
>...
> }
>
> T
IPA does not allow constant propagation on parameter that is used to control
function recursion.
recur_fn (i)
{
if ( !terminate_recursion (i))
{
...
recur_fn (i + 1);
...
}
...
}
This patch is composed to enable multi-versioning for self-recursive function,
and ve
19 matches
Mail list logo
