Re: [PATCH] Use x{v,}asprintf some more

2014-12-31 Thread Uros Bizjak
On Fri, Dec 26, 2014 at 2:00 PM, Uros Bizjak wrote: > This patch uses x{v,}asprintf where the result of the function is unused. > > 2014-12-26 Uros Bizjak > > * diagnostic.c (build_message_string): Use xvasprintf. > * final.c (output_operand_lossage): Use xvasprintf and xasprintf. >

Re: [PATCH] Use x{v,}asprintf some more

2014-12-27 Thread Uros Bizjak
On Fri, Dec 26, 2014 at 9:52 PM, Andi Kleen wrote: > Uros Bizjak writes: > >> Hello! >> >> This patch uses x{v,}asprintf where the result of the function is unused. > > I would be careful with it. Some old glibc versions have an asprintf > that corrupts memory. If you do this force the libiberty

Re: [PATCH] Use x{v,}asprintf some more

2014-12-26 Thread Andi Kleen
Uros Bizjak writes: > Hello! > > This patch uses x{v,}asprintf where the result of the function is unused. I would be careful with it. Some old glibc versions have an asprintf that corrupts memory. If you do this force the libiberty version unconditionally. -Andi -- a...@linux.intel.com -- Sp

[PATCH] Use x{v,}asprintf some more

2014-12-26 Thread Uros Bizjak
Hello! This patch uses x{v,}asprintf where the result of the function is unused. 2014-12-26 Uros Bizjak * diagnostic.c (build_message_string): Use xvasprintf. * final.c (output_operand_lossage): Use xvasprintf and xasprintf. * lto-wrapper.c (merge_and_complain): Use xasprintf.