Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.2)

2018-04-30 Thread Joseph Myers
On Mon, 30 Apr 2018, Will Hawkins wrote: > I agree! It was, however, the closest of all the categories that I > could find that seemed to match the warning that I am trying to emit. > I will go back and review the categories and see if there is something > that I missed. If there isn't a

Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.2)

2018-04-30 Thread Will Hawkins
On Mon, Apr 30, 2018 at 7:51 AM, Joseph Myers wrote: > On Sat, 28 Apr 2018, Will Hawkins wrote: > >> +{ >> + warning (OPT_Wignored_qualifiers, "asm-specifier is ignored in " >> + "typedef declaration"); > > This does not match the documented semantics

Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.2)

2018-04-30 Thread Joseph Myers
On Sat, 28 Apr 2018, Will Hawkins wrote: > +{ > + warning (OPT_Wignored_qualifiers, "asm-specifier is ignored in " > + "typedef declaration"); This does not match the documented semantics of -Wignored-qualifiers. I don't think it's appropriate to expand those semantics to

Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.2)

2018-04-28 Thread Will Hawkins
Thanks to Mr. Meyers for his comments. Here is an updated version of the patch. Test cases are included this time. Tested with 'make bootstrap' on x86_64-pc-linux-gnu. Results from make -k check available upon request. I hope that this one is better! Thanks again for everyone's patience! Will