Re: [PATCH] c++: -Wconversion vs value-dependent expressions [PR99331]

2021-03-08 Thread Marek Polacek via Gcc-patches
On Mon, Mar 08, 2021 at 06:10:05PM -0700, Martin Sebor wrote: > On 3/5/21 3:03 PM, Jason Merrill via Gcc-patches wrote: > > On 3/4/21 9:37 PM, Marek Polacek wrote: > > > This PR complains that we issue a -Wconversion warning in > > > > > >    template struct X {}; > > >    template X foo(); > >

Re: [PATCH] c++: -Wconversion vs value-dependent expressions [PR99331]

2021-03-08 Thread Martin Sebor via Gcc-patches
On 3/5/21 3:03 PM, Jason Merrill via Gcc-patches wrote: On 3/4/21 9:37 PM, Marek Polacek wrote: This PR complains that we issue a -Wconversion warning in    template struct X {};    template X foo(); saying "conversion from 'long unsigned int' to 'int' may change value". While it's not

Re: [PATCH] c++: -Wconversion vs value-dependent expressions [PR99331]

2021-03-05 Thread Jason Merrill via Gcc-patches
On 3/4/21 9:37 PM, Marek Polacek wrote: This PR complains that we issue a -Wconversion warning in template struct X {}; template X foo(); saying "conversion from 'long unsigned int' to 'int' may change value". While it's not technically wrong, I suspect -Wconversion warnings aren't all

[PATCH] c++: -Wconversion vs value-dependent expressions [PR99331]

2021-03-04 Thread Marek Polacek via Gcc-patches
This PR complains that we issue a -Wconversion warning in template struct X {}; template X foo(); saying "conversion from 'long unsigned int' to 'int' may change value". While it's not technically wrong, I suspect -Wconversion warnings aren't all that useful for value-dependent