Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-17 Thread Jason Merrill via Gcc-patches
On 12/17/20 12:24 PM, Patrick Palka wrote: On Thu, 17 Dec 2020, Patrick Palka wrote: On Fri, Dec 11, 2020 at 4:55 PM Patrick Palka wrote: On Fri, 11 Dec 2020, Jason Merrill wrote: On 12/11/20 10:31 AM, Patrick Palka wrote: On Thu, 10 Dec 2020, Patrick Palka wrote: On Thu, 10 Dec 2020,

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-17 Thread Patrick Palka via Gcc-patches
On Thu, 17 Dec 2020, Patrick Palka wrote: > On Fri, Dec 11, 2020 at 4:55 PM Patrick Palka wrote: > > > > On Fri, 11 Dec 2020, Jason Merrill wrote: > > > > > On 12/11/20 10:31 AM, Patrick Palka wrote: > > > > On Thu, 10 Dec 2020, Patrick Palka wrote: > > > > > > > > > On Thu, 10 Dec 2020, Jason

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-17 Thread Patrick Palka via Gcc-patches
On Fri, Dec 11, 2020 at 4:55 PM Patrick Palka wrote: > > On Fri, 11 Dec 2020, Jason Merrill wrote: > > > On 12/11/20 10:31 AM, Patrick Palka wrote: > > > On Thu, 10 Dec 2020, Patrick Palka wrote: > > > > > > > On Thu, 10 Dec 2020, Jason Merrill wrote: > > > > > > > > > On 12/10/20 11:21 AM,

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-11 Thread Patrick Palka via Gcc-patches
On Fri, 11 Dec 2020, Jason Merrill wrote: > On 12/11/20 10:31 AM, Patrick Palka wrote: > > On Thu, 10 Dec 2020, Patrick Palka wrote: > > > > > On Thu, 10 Dec 2020, Jason Merrill wrote: > > > > > > > On 12/10/20 11:21 AM, Patrick Palka wrote: > > > > > This implements lightweight heuristical

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-11 Thread Jason Merrill via Gcc-patches
On 12/11/20 10:31 AM, Patrick Palka wrote: On Thu, 10 Dec 2020, Patrick Palka wrote: On Thu, 10 Dec 2020, Jason Merrill wrote: On 12/10/20 11:21 AM, Patrick Palka wrote: This implements lightweight heuristical detection and diagnosing of satisfaction results that change at different points

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-11 Thread Patrick Palka via Gcc-patches
On Thu, 10 Dec 2020, Patrick Palka wrote: > On Thu, 10 Dec 2020, Jason Merrill wrote: > > > On 12/10/20 11:21 AM, Patrick Palka wrote: > > > This implements lightweight heuristical detection and diagnosing of > > > satisfaction results that change at different points in the program, > > > which

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-10 Thread Patrick Palka via Gcc-patches
On Thu, 10 Dec 2020, Jason Merrill wrote: > On 12/10/20 11:21 AM, Patrick Palka wrote: > > This implements lightweight heuristical detection and diagnosing of > > satisfaction results that change at different points in the program, > > which renders the program as ill-formed NDR as of P2014.

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-10 Thread Jason Merrill via Gcc-patches
On 12/10/20 11:21 AM, Patrick Palka wrote: This implements lightweight heuristical detection and diagnosing of satisfaction results that change at different points in the program, which renders the program as ill-formed NDR as of P2014. We've recently started to more aggressively cache

Re: [PATCH] c++: Diagnose unstable satisfaction results

2020-12-10 Thread David Malcolm via Gcc-patches
On Thu, 2020-12-10 at 11:21 -0500, Patrick Palka via Gcc-patches wrote: > + if (entry->diagnose_instability) > + { > + error_at (EXPR_LOCATION (ATOMIC_CONSTR_EXPR (entry->atom)), > + "satisfaction value of atomic constraint %qE changed " > +

[PATCH] c++: Diagnose unstable satisfaction results

2020-12-10 Thread Patrick Palka via Gcc-patches
This implements lightweight heuristical detection and diagnosing of satisfaction results that change at different points in the program, which renders the program as ill-formed NDR as of P2014. We've recently started to more aggressively cache satisfaction results, and so the goal here is to make