Re: [PATCH] c++: Fix hashing and testing for equality of ATOMIC_CONST_EXPRs

2020-02-13 Thread Patrick Palka
On Fri, 14 Feb 2020, Jason Merrill wrote: > On 2/12/20 5:15 PM, Patrick Palka wrote: > > Two equal atomic constraint expressions do not necessarily share the same > > tree, > > so we can't assume that two ATOMIC_CONST_EXPRs are equal if and only if they > > point to the same tree. > > This is inc

Re: [PATCH] c++: Fix hashing and testing for equality of ATOMIC_CONST_EXPRs

2020-02-13 Thread Jason Merrill
On 2/12/20 5:15 PM, Patrick Palka wrote: Two equal atomic constraint expressions do not necessarily share the same tree, so we can't assume that two ATOMIC_CONST_EXPRs are equal if and only if they point to the same tree. This is incorrect; comparison of atomic constraints is based on them com

[PATCH] c++: Fix hashing and testing for equality of ATOMIC_CONST_EXPRs

2020-02-12 Thread Patrick Palka
Two equal atomic constraint expressions do not necessarily share the same tree, so we can't assume that two ATOMIC_CONST_EXPRs are equal if and only if they point to the same tree. The main consequence of this invalid assumption is that the constraint subsumption checker may reject a valid partial