Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-10 Thread Jason Merrill via Gcc-patches
On 3/9/20 4:34 PM, Marek Polacek wrote: On Mon, Mar 09, 2020 at 04:25:00PM -0400, Marek Polacek wrote: On Mon, Mar 09, 2020 at 03:37:56PM -0400, Jason Merrill wrote: On 3/9/20 9:40 AM, Marek Polacek wrote: On Mon, Mar 09, 2020 at 09:19:30AM -0400, Jason Merrill wrote: On 3/9/20 8:58 AM,

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-09 Thread Marek Polacek
On Mon, Mar 09, 2020 at 04:25:00PM -0400, Marek Polacek wrote: > On Mon, Mar 09, 2020 at 03:37:56PM -0400, Jason Merrill wrote: > > On 3/9/20 9:40 AM, Marek Polacek wrote: > > > On Mon, Mar 09, 2020 at 09:19:30AM -0400, Jason Merrill wrote: > > > > On 3/9/20 8:58 AM, Jakub Jelinek wrote: > > > > >

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-09 Thread Marek Polacek
On Mon, Mar 09, 2020 at 03:37:56PM -0400, Jason Merrill wrote: > On 3/9/20 9:40 AM, Marek Polacek wrote: > > On Mon, Mar 09, 2020 at 09:19:30AM -0400, Jason Merrill wrote: > > > On 3/9/20 8:58 AM, Jakub Jelinek wrote: > > > > On Fri, Mar 06, 2020 at 07:43:43PM -0500, Jason Merrill wrote: > > > > >

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-09 Thread Jason Merrill
On 3/9/20 9:40 AM, Marek Polacek wrote: On Mon, Mar 09, 2020 at 09:19:30AM -0400, Jason Merrill wrote: On 3/9/20 8:58 AM, Jakub Jelinek wrote: On Fri, Mar 06, 2020 at 07:43:43PM -0500, Jason Merrill wrote: On 3/6/20 6:54 PM, Marek Polacek wrote: I got a report that building Chromium fails

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-09 Thread Marek Polacek
On Mon, Mar 09, 2020 at 09:19:30AM -0400, Jason Merrill wrote: > On 3/9/20 8:58 AM, Jakub Jelinek wrote: > > On Fri, Mar 06, 2020 at 07:43:43PM -0500, Jason Merrill wrote: > > > On 3/6/20 6:54 PM, Marek Polacek wrote: > > > > I got a report that building Chromium fails with the "modifying a const

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-09 Thread Jason Merrill
On 3/9/20 8:58 AM, Jakub Jelinek wrote: On Fri, Mar 06, 2020 at 07:43:43PM -0500, Jason Merrill wrote: On 3/6/20 6:54 PM, Marek Polacek wrote: I got a report that building Chromium fails with the "modifying a const object" error. After some poking I realized it's a bug in GCC, not in their

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-09 Thread Jakub Jelinek
On Fri, Mar 06, 2020 at 07:43:43PM -0500, Jason Merrill wrote: > On 3/6/20 6:54 PM, Marek Polacek wrote: > > I got a report that building Chromium fails with the "modifying a const > > object" error. After some poking I realized it's a bug in GCC, not in > > their codebase. > > > > Much like

Re: [PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-06 Thread Jason Merrill
On 3/6/20 6:54 PM, Marek Polacek wrote: I got a report that building Chromium fails with the "modifying a const object" error. After some poking I realized it's a bug in GCC, not in their codebase. Much like with ARRAY_REFs, which can be const even though the array itself isn't, COMPONENT_REFs

[PATCH] c++: Fix wrong modifying const object error for COMPONENT_REF [PR94074]

2020-03-06 Thread Marek Polacek
I got a report that building Chromium fails with the "modifying a const object" error. After some poking I realized it's a bug in GCC, not in their codebase. Much like with ARRAY_REFs, which can be const even though the array itself isn't, COMPONENT_REFs can be const although neither the object