Re: [PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-25 Thread Jason Merrill
On 6/25/24 15:07, Marek Polacek wrote: On Tue, Jun 25, 2024 at 06:22:56PM +0100, Jonathan Wakely wrote: On Tue, 25 Jun 2024 at 16:17, Jason Merrill wrote: On 6/25/24 07:15, Jonathan Wakely wrote: On Tue, 25 Jun 2024 at 03:12, Jason Merrill wrote: On 6/18/24 10:31, Marek Polacek wrote: Bo

Re: [PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-25 Thread Marek Polacek
On Tue, Jun 25, 2024 at 06:22:56PM +0100, Jonathan Wakely wrote: > On Tue, 25 Jun 2024 at 16:17, Jason Merrill wrote: > > > > On 6/25/24 07:15, Jonathan Wakely wrote: > > > On Tue, 25 Jun 2024 at 03:12, Jason Merrill wrote: > > >> > > >> On 6/18/24 10:31, Marek Polacek wrote: > > >>> Bootstrapped

Re: [PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-25 Thread Jonathan Wakely
On Tue, 25 Jun 2024 at 16:17, Jason Merrill wrote: > > On 6/25/24 07:15, Jonathan Wakely wrote: > > On Tue, 25 Jun 2024 at 03:12, Jason Merrill wrote: > >> > >> On 6/18/24 10:31, Marek Polacek wrote: > >>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? > >> > >> Makes sense to

Re: [PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-25 Thread Jason Merrill
On 6/25/24 07:15, Jonathan Wakely wrote: On Tue, 25 Jun 2024 at 03:12, Jason Merrill wrote: On 6/18/24 10:31, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? Makes sense to me, though probably the [meta.unary.prop] table should be adjusted in the same

Re: [PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-25 Thread Jonathan Wakely
On Tue, 25 Jun 2024 at 03:12, Jason Merrill wrote: > > On 6/18/24 10:31, Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? > > Makes sense to me, though probably the [meta.unary.prop] table should be > adjusted in the same way. Jonathan, what do you think

Re: [PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-24 Thread Jason Merrill
On 6/18/24 10:31, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? Makes sense to me, though probably the [meta.unary.prop] table should be adjusted in the same way. Jonathan, what do you think? -- >8 -- Here we started to ICE with r13-25: in check_tr

[PATCH] c++: ICE with __has_unique_object_representations [PR115476]

2024-06-18 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? -- >8 -- Here we started to ICE with r13-25: in check_trait_type, for "X[]" we return true here: if (kind == 1 && TREE_CODE (type) == ARRAY_TYPE && !TYPE_DOMAIN (type)) return true; // Array of unknown bound. Don't care abou