[PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-05 Thread Anthony Sharp via Gcc-patches
This patch fixes PR17314 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=17314). Previously, when class C attempted to access member a declared in class A through class B, where class B privately inherits from A and class C inherits from B, GCC would correctly report an access violation, but would er

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-07 Thread Jason Merrill via Gcc-patches
On 1/5/21 9:24 AM, Anthony Sharp via Gcc-patches wrote: This patch fixes PR17314 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=17314). Previously, when class C attempted to access member a declared in class A through class B, where class B privately inherits from A and class C inherits from B, GC

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-08 Thread Anthony Sharp via Gcc-patches
Hi Jason, Thank you! > To start with, do you have a copyright assignment on file or in the > works already? Good point. I incorrectly assumed it would only be a minor contribution copyright-wise. Mr Edelsohn gave me a template which I've now filled out and sent to ass...@gnu.org. I'm assuming I

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/8/21 7:38 PM, Anthony Sharp wrote: Hi Jason, Thank you! To start with, do you have a copyright assignment on file or in the works already? Good point. I incorrectly assumed it would only be a minor contribution copyright-wise. > Mr Edelsohn gave me a template which I've now filled out a

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-21 Thread Anthony Sharp via Gcc-patches
Hi Jason, I've finally completed my copyright assignment form. I've attached it to this email for reference. > You don't need write access to the main repository to use these commands > on your local copy. One nice thing about git compared to svn is that > you don't need to touch the server for

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/21/21 2:28 PM, Anthony Sharp wrote: Hi Jason, I've finally completed my copyright assignment form. I've attached it to this email for reference. You don't need write access to the main repository to use these commands on your local copy. One nice thing about git compared to svn is that y

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/21/21 2:28 PM, Anthony Sharp wrote: Hi Jason, I've finally completed my copyright assignment form. I've attached it to this email for reference. You don't need write access to the main repository to use these commands on your local copy. One nice thing about git compared to svn is that y

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-22 Thread Anthony Sharp via Gcc-patches
Hi Jason, Thanks for getting back to me so quickly. > Why two gcc-comit-mklog? That would generate the log entries twice. It did in fact generate the log entries twice, but I deleted out the second copy. Perhaps it would have made more sense to do git commit --amend instead. > Instead of makin

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-22 Thread Jason Merrill via Gcc-patches
On 1/22/21 3:07 PM, Anthony Sharp wrote: Hi Jason, Thanks for getting back to me so quickly. > Why two gcc-comit-mklog?  That would generate the log entries twice. It did in fact generate the log entries twice, but I deleted out the second copy. Perhaps it would have made more sense to do gi

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-22 Thread Anthony Sharp via Gcc-patches
Hi Jason, Attached changes. I just edited the patch file directly. Kind regards, Anthony From 7984020f16e715017e62b8637d2e69c1aec3478a Mon Sep 17 00:00:00 2001 From: Anthony Sharp Date: Thu, 21 Jan 2021 15:26:25 + Subject: [PATCH] c++: Private inheritance access diagnostics fix [PR17314