Re: [PATCH] c++: recognize class-scope non-template dguides [PR79501]

2021-08-11 Thread Jason Merrill via Gcc-patches
s.type + && !decl_specifiers.any_type_specifiers_p + && ctor_dtor_or_conv_p <= 0 + && cxx_dialect >= cxx17) Looks like you could factor more of the tests into the new function. That works nicely, like so? Bootstrap and regtesting in

Re: [PATCH] c++: recognize class-scope non-template dguides [PR79501]

2021-08-11 Thread Patrick Palka via Gcc-patches
_parser_error_occurred (parser)) > > warn_about_ambiguous_parse (decl_specifiers, declarator); > > @@ -26719,6 +26734,15 @@ cp_parser_member_declaration (cp_parser* parser) > > cp_lexer_consume_token (parser->lexer); > > goto out; > >

Re: [PATCH] c++: recognize class-scope non-template dguides [PR79501]

2021-08-11 Thread Jason Merrill via Gcc-patches
On 8/9/21 1:16 PM, Patrick Palka wrote: It looks like we still don't recognize class-scope non-template deduction guides even after r12-2260. This is because deduction guides are handled in cp_parser_init_declarator after calling cp_parser_declarator, but in the class-scope non-template case we

[PATCH] c++: recognize class-scope non-template dguides [PR79501]

2021-08-09 Thread Patrick Palka via Gcc-patches
It looks like we still don't recognize class-scope non-template deduction guides even after r12-2260. This is because deduction guides are handled in cp_parser_init_declarator after calling cp_parser_declarator, but in the class-scope non-template case we call cp_parser_declarator directly from c