[PATCH] c: [PR32122] Require pointer types for computed gotos

2021-09-19 Thread apinski--- via Gcc-patches
From: Andrew Pinski So GCC has always accepted non-pointer types in computed gotos but that was wrong based on the documentation: Any expression of type void * is allowed. So this fixes the problem by requiring the type to be a pointer type. OK? Bootstrapped and tested on x86_64-linux-gnu with

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-09-20 Thread Jeff Law via Gcc-patches
On 9/19/2021 10:14 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski So GCC has always accepted non-pointer types in computed gotos but that was wrong based on the documentation: Any expression of type void * is allowed. So this fixes the problem by requiring the type to be a pointe

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-09-29 Thread Jakub Jelinek via Gcc-patches
On Mon, Sep 20, 2021 at 09:41:03AM -0600, Jeff Law via Gcc-patches wrote: > > > On 9/19/2021 10:14 PM, apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > > > So GCC has always accepted non-pointer types in computed gotos but > > that was wrong based on the documentation: > > Any expr

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-09-29 Thread Andrew Pinski via Gcc-patches
On Wed, Sep 29, 2021 at 1:06 AM Jakub Jelinek via Gcc-patches wrote: > > On Mon, Sep 20, 2021 at 09:41:03AM -0600, Jeff Law via Gcc-patches wrote: > > > > > > On 9/19/2021 10:14 PM, apinski--- via Gcc-patches wrote: > > > From: Andrew Pinski > > > > > > So GCC has always accepted non-pointer type

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-09-29 Thread Jeff Law via Gcc-patches
On 9/29/2021 2:05 AM, Jakub Jelinek wrote: On Mon, Sep 20, 2021 at 09:41:03AM -0600, Jeff Law via Gcc-patches wrote: On 9/19/2021 10:14 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski So GCC has always accepted non-pointer types in computed gotos but that was wrong based on the

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-09-29 Thread Jeff Law via Gcc-patches
On 9/29/2021 2:08 AM, Andrew Pinski wrote: On Wed, Sep 29, 2021 at 1:06 AM Jakub Jelinek via Gcc-patches wrote: On Mon, Sep 20, 2021 at 09:41:03AM -0600, Jeff Law via Gcc-patches wrote: On 9/19/2021 10:14 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski So GCC has always accept

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-10-01 Thread Eric Gallager via Gcc-patches
On Mon, Sep 20, 2021 at 12:15 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > So GCC has always accepted non-pointer types in computed gotos but > that was wrong based on the documentation: > Any expression of type void * is allowed. > > So this fixes the problem by requiring the

Re: [PATCH] c: [PR32122] Require pointer types for computed gotos

2021-10-01 Thread Andrew Pinski via Gcc-patches
On Fri, Oct 1, 2021 at 4:03 AM Eric Gallager via Gcc-patches wrote: > > On Mon, Sep 20, 2021 at 12:15 AM apinski--- via Gcc-patches > wrote: > > > > From: Andrew Pinski > > > > So GCC has always accepted non-pointer types in computed gotos but > > that was wrong based on the documentation: > > A