Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-04 Thread Alexandre Oliva via Gcc-patches
On Aug 3, 2022, Eric Gallager wrote: > OK, after reviewing the surrounding code, I think it makes sense; do > you want to commit it, or should I? Please proceed, if you have the cycles to give it a round of meaningful testing (as in, including reconfigure with configure-generated as, and also w

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-03 Thread Eric Gallager via Gcc-patches
On Tue, Aug 2, 2022 at 11:33 PM Alexandre Oliva wrote: > > On Aug 2, 2022, Eric Gallager wrote: > > > On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva wrote: > > >> -elif test -x as$build_exeext; then > >> +elif test -x as$build_exeext \ > >> + && { test "x$build_exeext" != "x" \ > >> +

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-02 Thread Alexandre Oliva via Gcc-patches
On Aug 2, 2022, Eric Gallager wrote: > On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva wrote: >> -elif test -x as$build_exeext; then >> +elif test -x as$build_exeext \ >> + && { test "x$build_exeext" != "x" \ >> +|| test "x`grep '^# Invoke as, ld or nm from the build tree' \ >

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-02 Thread Eric Gallager via Gcc-patches
On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva wrote: > > Hello, Eric, > > Thanks for looking into this. > > On Aug 1, 2022, Eric Gallager via Gcc-patches > wrote: > > >> This just reassigns the value that was retrieved a couple of lines > >> above from the very same variable. > > > Oh, ok, so

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-01 Thread Alexandre Oliva via Gcc-patches
Hello, Eric, Thanks for looking into this. On Aug 1, 2022, Eric Gallager via Gcc-patches wrote: >> This just reassigns the value that was retrieved a couple of lines >> above from the very same variable. > Oh, ok, so I guess this isn't necessary after all? Yeah, I don't see how this patch co

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-01 Thread Eric Gallager via Gcc-patches
On Mon, Aug 1, 2022 at 3:54 AM Andreas Schwab wrote: > > On Jul 31 2022, Eric Gallager via Gcc-patches wrote: > > > It just makes the configure script respect the --with-build-time-tools > > flag. > > Why does it make any difference? > See the original bug report: https://gcc.gnu.org/bugzilla/sho

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-01 Thread Andreas Schwab via Gcc-patches
On Jul 31 2022, Eric Gallager via Gcc-patches wrote: > It just makes the configure script respect the --with-build-time-tools > flag. Why does it make any difference? > diff --git a/configure b/configure > index 65d7078dbe7..4d46b94ebc4 100755 > --- a/configure > +++ b/configure > @@ -12850,7 +1

[PATCH] configure: respect --with-build-time-tools [PR43301]

2022-07-31 Thread Eric Gallager via Gcc-patches
Hi, there's been a patch sitting in bug 43301 for over a decade that I think still makes sense to apply, so I rebased it against current trunk and found that it still applies. It just makes the configure script respect the --with-build-time-tools flag. OK to commit? ChangeLog: PR bootstrap/43