Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

On 8/26/25 11:54, H.J. Lu wrote: > On Mon, Aug 25, 2025 at 12:11 PM David Faust wrote: >> >> >> >> On 8/25/25 10:33, Indu Bhagat wrote: >>> On 8/25/25 8:08 AM, David Faust wrote: On 8/22/25 23:49, Indu Bhagat wrote: > On 8/6/25 9:26 AM, David Faust wrote: >> CTF array enc

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

On Mon, Aug 25, 2025 at 12:11 PM David Faust wrote: > > > > On 8/25/25 10:33, Indu Bhagat wrote: > > On 8/25/25 8:08 AM, David Faust wrote: > >> > >> > >> On 8/22/25 23:49, Indu Bhagat wrote: > >>> On 8/6/25 9:26 AM, David Faust wrote: > CTF array encoding uses uint32 for number of elements.

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

On 8/25/25 10:33, Indu Bhagat wrote: > On 8/25/25 8:08 AM, David Faust wrote: >> >> >> On 8/22/25 23:49, Indu Bhagat wrote: >>> On 8/6/25 9:26 AM, David Faust wrote: CTF array encoding uses uint32 for number of elements. This means there is a hard upper limit on array types which the

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

On 8/25/25 8:08 AM, David Faust wrote: On 8/22/25 23:49, Indu Bhagat wrote: On 8/6/25 9:26 AM, David Faust wrote: CTF array encoding uses uint32 for number of elements. This means there is a hard upper limit on array types which the format can represent. Hi David, Thanks for the patch.

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

Hi David, This LGTM. Good catch! Bruce McCulloch On 8/6/25 9:26 AM, David Faust wrote: CTF array encoding uses uint32 for number of elements. This means there is a hard upper limit on array types which the format can represent. GCC internally was also using a uint32_t for this, which would o

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

On 8/22/25 23:49, Indu Bhagat wrote: > On 8/6/25 9:26 AM, David Faust wrote: >> CTF array encoding uses uint32 for number of elements. This means there >> is a hard upper limit on array types which the format can represent. >> > > Hi David, > > Thanks for the patch. > > Few nits. But otherwi

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

On 8/6/25 9:26 AM, David Faust wrote: CTF array encoding uses uint32 for number of elements. This means there is a hard upper limit on array types which the format can represent. Hi David, Thanks for the patch. Few nits. But otherwise the patch looks good. As you noted in the bugzilla, mo

Re: [PATCH] ctf: avoid overflow for array num elements [PR121411]

Ping. Note: this patch doesn't fully resolve the PR (see discussion there) but it does fix one existing truncation bug. Thanks! On 8/6/25 09:26, David Faust wrote: > CTF array encoding uses uint32 for number of elements. This means there > is a hard upper limit on array types which the format c

[PATCH] ctf: avoid overflow for array num elements [PR121411]

CTF array encoding uses uint32 for number of elements. This means there is a hard upper limit on array types which the format can represent. GCC internally was also using a uint32_t for this, which would overflow when translating from DWARF for arrays with more with more than UINT32_MAX elements.