[PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-09-15 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 10, 2020 at 01:45:50PM +0200, Jakub Jelinek wrote: > On Thu, Sep 10, 2020 at 01:16:57PM +0200, Jakub Jelinek via Gcc-patches wrote: > > As for the test assembly, I'd say we should take > > #define F void foo (void) {} > > F > > compile it with > > gcc -S -O2 -g1 -dA -gno-as-loc-support

Re: [PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-09-16 Thread Mark Wielaard
Hi, On Tue, 2020-09-15 at 20:40 +0200, Jakub Jelinek wrote: > Ok, here it is in patch form. > I've briefly tested it, with the older binutils I have around (no --gdwarf-N > support), with latest gas (--gdwarf-N that can be passed to as even when > compiling C/C++ etc. code and emitting .debug_line

Re: [PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-09-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Sep 16, 2020 at 02:33:03PM +0200, Mark Wielaard wrote: > > 2020-09-15 Jakub Jelinek > > > > * configure.ac (HAVE_AS_GDWARF_5_DEBUG_FLAG, > > HAVE_AS_WORKING_DWARF_4_FLAG): New tests. > > * gcc.c (ASM_DEBUG_DWARF_OPTION): Define. > > (ASM_DEBUG_SPEC): Use ASM_DEBUG_DWARF_

Re: [PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-09-18 Thread Mark Wielaard
Hi, On Tue, 2020-09-15 at 20:40 +0200, Jakub Jelinek wrote: > Ok, here it is in patch form. > I've briefly tested it, with the older binutils I have around (no --gdwarf-N > support), with latest gas (--gdwarf-N that can be passed to as even when > compiling C/C++ etc. code and emitting .debug_line

Re: [PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-10-06 Thread Mark Wielaard
Hi, On Fri, 2020-09-18 at 17:21 +0200, Mark Wielaard wrote: > On Tue, 2020-09-15 at 20:40 +0200, Jakub Jelinek wrote: > > Ok, here it is in patch form. > > I've briefly tested it, with the older binutils I have around (no --gdwarf-N > > support), with latest gas (--gdwarf-N that can be passed to a

Re: [PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-10-06 Thread Jason Merrill via Gcc-patches
On 10/6/20 11:54 AM, Mark Wielaard wrote: Hi, On Fri, 2020-09-18 at 17:21 +0200, Mark Wielaard wrote: On Tue, 2020-09-15 at 20:40 +0200, Jakub Jelinek wrote: Ok, here it is in patch form. I've briefly tested it, with the older binutils I have around (no --gdwarf-N support), with latest gas (--

Re: [PATCH] debug: Pass --gdwarf-N to assembler if fixed gas is detected during configure

2020-10-07 Thread Mark Wielaard
Hi, On Tue, 2020-10-06 at 16:57 -0400, Jason Merrill wrote: > All three of these patches (Jakub's, and your two) look good to me, > except that your add_filepath_AT_string patch is missing comments on > some of the new functions. I added documentation for the two new functions missing comments