Re: [PATCH] diagnostics: fix end-points of ranges within macros (PR c++/79300)

2017-07-03 Thread Jeff Law
On 02/02/2017 01:53 PM, David Malcolm wrote: > PR c++/79300 identifies an issue in which diagnostics_show_locus > prints the wrong end-point for a range within a macro: > >assert ((p + val_size) - buf == encoded_len); >~^~~~ > > as opposed to: > >assert

Re: [PATCH] diagnostics: fix end-points of ranges within macros (PR c++/79300)

2017-02-03 Thread Jeff Law
On 02/03/2017 01:52 PM, David Malcolm wrote: IIRC you had another issue that was borderline, but which we did want to move forward on gcc-7. The reported testcase was a problem with a new warning, but the underlying issue could (in theory) be tripped for existing warnings. RIght? I think

Re: [PATCH] diagnostics: fix end-points of ranges within macros (PR c++/79300)

2017-02-03 Thread David Malcolm
On Fri, 2017-02-03 at 13:28 -0700, Jeff Law wrote: > On 02/02/2017 01:53 PM, David Malcolm wrote: > > PR c++/79300 identifies an issue in which diagnostics_show_locus > > prints the wrong end-point for a range within a macro: > > > >assert ((p + val_size) - buf == encoded_len); > >

Re: [PATCH] diagnostics: fix end-points of ranges within macros (PR c++/79300)

2017-02-03 Thread Jeff Law
On 02/02/2017 01:53 PM, David Malcolm wrote: PR c++/79300 identifies an issue in which diagnostics_show_locus prints the wrong end-point for a range within a macro: assert ((p + val_size) - buf == encoded_len); ~^~~~ as opposed to: assert ((p + val_size) -

[PATCH] diagnostics: fix end-points of ranges within macros (PR c++/79300)

2017-02-02 Thread David Malcolm
PR c++/79300 identifies an issue in which diagnostics_show_locus prints the wrong end-point for a range within a macro: assert ((p + val_size) - buf == encoded_len); ~^~~~ as opposed to: assert ((p + val_size) - buf == encoded_len);