Re: [PATCH] expr: catch more `a*bool` while expanding [PR 112935]

2023-12-10 Thread Richard Biener
On Sun, Dec 10, 2023 at 10:30 AM Xi Ruoyao wrote: > > On Sun, 2023-12-10 at 01:21 -0800, Andrew Pinski wrote: > > diff --git a/gcc/expr.cc b/gcc/expr.cc > > index 6da51f2aca2..4686cacd22f 100644 > > --- a/gcc/expr.cc > > +++ b/gcc/expr.cc > > @@ -10209,8 +10209,9 @@ expand_expr_real_2 (sepops ops,

Re: [PATCH] expr: catch more `a*bool` while expanding [PR 112935]

2023-12-10 Thread Richard Biener
On Sun, Dec 10, 2023 at 10:21 AM Andrew Pinski wrote: > > After r14-1655-g52c92fb3f40050 (and the other commits > which touch zero_one_valued_p), we end up with a with > `bool * a` but where the bool is an SSA name that might not > have non-zero bits set on it (to 0x1) even though it > does the no

Re: [PATCH] expr: catch more `a*bool` while expanding [PR 112935]

2023-12-10 Thread Xi Ruoyao
On Sun, 2023-12-10 at 01:21 -0800, Andrew Pinski wrote: > diff --git a/gcc/expr.cc b/gcc/expr.cc > index 6da51f2aca2..4686cacd22f 100644 > --- a/gcc/expr.cc > +++ b/gcc/expr.cc > @@ -10209,8 +10209,9 @@ expand_expr_real_2 (sepops ops, rtx target, > machine_mode tmode, >    /* Expand X*Y as X&-Y

[PATCH] expr: catch more `a*bool` while expanding [PR 112935]

2023-12-10 Thread Andrew Pinski
After r14-1655-g52c92fb3f40050 (and the other commits which touch zero_one_valued_p), we end up with a with `bool * a` but where the bool is an SSA name that might not have non-zero bits set on it (to 0x1) even though it does the non-zero bits would be 0x1. The case of coremarks, it is only phiopt4