Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-30 Thread Jeff Law
On 09/30/2016 10:18 AM, Bruce Korb wrote: Hi Tadek, Looks good to me. Thank you. Clear to send (push). Committed on behalf of Tadek. Thanks, jeff

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-30 Thread Bruce Korb
Hi Tadek, Looks good to me. Thank you. Clear to send (push).

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Tadek Kijkowski
The fixincl executable uses system function to call applyfix or to direcly patch a header file, with parameters enclosed in single quotes. The problem is that MinGW system function just calls cmd.exe, which doesn't strip quotes from parameters and completely ignores quotes for embedding spaces in p

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Tadek Kijkowski
Hold on. I have much improved version almost ready. It passes all the tests now. 2016-09-30 0:15 GMT+02:00 Bruce Korb : > I usually try to catch emails with "fixincludes" in the title. > Can I please get a copy of the original patch? Thanks. > > > On 09/29/16 11:44, Jeff Law wrote: >> >> On 09/22

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Bruce Korb
OK, I found it. Looks like my MUA is getting too aggressive with its filtering. What Jeff said, plus I would prefer the tail end looking like: + +#else + +#define system_with_shell system // normal call + +#endif /* defined(__MINGW32__) */ and modifying the call to use "system_with_shell". The p

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Bruce Korb
I usually try to catch emails with "fixincludes" in the title. Can I please get a copy of the original patch? Thanks. On 09/29/16 11:44, Jeff Law wrote: On 09/22/2016 11:26 PM, Tadek Kijkowski wrote: The fixincl executable uses system function to call applyfix or to direcly patch a header file

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Jeff Law
On 09/22/2016 11:26 PM, Tadek Kijkowski wrote: The fixincl executable uses system function to call applyfix or to direcly patch a header file, with parameters enclosed in single quotes. This problem is that MinGW system function just calls cmd.exe, which doesn't strip quotes from parameters and c

[PATCH] fixincludes: fix fixincludes for MinGW

2016-09-22 Thread Tadek Kijkowski
The fixincl executable uses system function to call applyfix or to direcly patch a header file, with parameters enclosed in single quotes. This problem is that MinGW system function just calls cmd.exe, which doesn't strip quotes from parameters and completely ignores quotes for embedding spaces in